New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add client socket Android benchmark #285
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flooey
approved these changes
Aug 8, 2017
benchmark.time(numMessages); | ||
} | ||
|
||
private final class JmhConfig implements Config { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CaliperConfig?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
nmittler
force-pushed
the
android_throughput_benchmarks
branch
2 times, most recently
from
August 8, 2017 14:20
28b8fb5
to
ad65f37
Compare
Refactoring the benchmark libraries a bit in the process: - Merged benchmark-openjdk with benchmark-jmh - Renamed EngineType->EngineFactory - Renamed SocketType->EndpointFactory, and made it an interface to match the changes with EngineFactory - Reverted benchmark-base to being a standalone library. Idea seems to prefer this to the same source being included from multiple projects. - Renamed PooledAllocator to NettyBufferAllocator.
nmittler
force-pushed
the
android_throughput_benchmarks
branch
from
August 8, 2017 16:43
ad65f37
to
fecfbd4
Compare
Here's the output for the same Nexus 6P I ran the previous benchmarks on:
|
nmittler
pushed a commit
that referenced
this pull request
Aug 10, 2017
Refactoring the benchmark libraries a bit in the process: - Merged benchmark-openjdk with benchmark-jmh - Renamed EngineType->EngineFactory - Renamed SocketType->EndpointFactory, and made it an interface to match the changes with EngineFactory - Reverted benchmark-base to being a standalone library. Idea seems to prefer this to the same source being included from multiple projects. - Renamed PooledAllocator to NettyBufferAllocator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring the benchmark libraries a bit in the process:
Merged benchmark-openjdk with benchmark-jmh
Renamed EngineType->EngineFactory
Renamed SocketType->EndpointFactory, and made it an interface to
match the changes with EngineFactory
Reverted benchmark-base to being a standalone library. Idea seems to
prefer this to the same source being included from multiple projects.
Renamed PooledAllocator to NettyBufferAllocator.