This repository has been archived by the owner on Jun 4, 2021. It is now read-only.
Add --client-config flag to fast_pusher #112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature faciliates more flexible authentication strategies when dealing with private registries.
smukherj1
reviewed
Nov 23, 2018
| class _DefaultKeychain(Keychain): | ||
| """This implements the default docker credential resolution.""" | ||
|
|
||
|
|
||
| def GetConfigDirectory(config_dir): |
There was a problem hiding this comment.
Does this need to be "def GetConfigDirectory(self, config_dir):" instead? I'm wondering if that is responsible for the travis failure
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature faciliates more flexible authentication strategies
when dealing with private registries.