Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Remove invalid proxy behavior of Http and RetryTransport #51

Closed
wants to merge 1 commit into from

Conversation

abergmeier
Copy link

Unless we make a proper proxy out of Http and RetryTransport, this generates a messed up object because one part of function calls go to
self and others delegate to _transport.

So only expose methods, which really delegate.

generates a messed up object because one part of function calls go to
self and others delegate to _transport.

So only expose methods, which really delegate.
@dekkagaijin
Copy link
Contributor

dekkagaijin commented Dec 27, 2017

We don't want to give up the type, but it looks like we want to use the cert functionality, so I'll make the changes. In retrospect, the retry transport's factory should have taken a callable for underlying transports.

I think that there aren't so many implementations that we can't proxy calls to underlying transports for add_credentials, add_certificate, clear_credentials, and request. I'll make the internal change for that.

@abergmeier
Copy link
Author

We don't want to give up the type

No problem. But then please make it a real proxy.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants