Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copybara info should be able to return the list of pending changes #3

Closed
mikelalcon opened this issue Feb 9, 2017 · 2 comments
Closed
Assignees

Comments

@mikelalcon
Copy link
Collaborator

Ideally we should honor origin_files. At least the glob roots. Would be great if we could honor the excludes too.

Probably this involves an option to origin.changes() to return the list of files in a change too.

@denian
Copy link
Contributor

denian commented Feb 13, 2017

This was fixed in b5ad5f3

@denian denian closed this as completed Feb 13, 2017
@ittaiz
Copy link
Contributor

ittaiz commented Feb 14, 2017

Awesome! Looks good, thanks!

copybara-staging bot pushed a commit that referenced this issue Jul 21, 2023
Included changes:

  - 288731ef9f7f688932bd50e704a91a45ec185f9b Update changelog and version for release 1.4.2 (#451)
  - 12dd004ffa1e31c196593f76238e75b80f62dd64 Allow .scl files in bzl_library (#450)
  - 0a34b7edf6dca8a224d26b73864a7092cbbe32e9 Avoid building build_test deps unnecessarily (#448)
  - caf2bc1ae197aea45aee80c2fd8845937097f00a Build with incompatible_disallow_empty_glob (#447)
  - 2f0bb4cec0297bb38f830a72fa8961bee057c3cd Fix spelling (#445)
  - a360c42f3d7c7697c8521ed831ebf94ff4120451 Trivial buildifier fix (#444)
  - 141432789c92e9db2402ef0be58e2a2d2c4dd1fd Update changelog and version for release 1.4.1 (#434)
  - cc477631c941fe9dda8ad6b13ef4ed9960ed4933 Update rules_go and gazelle deps to be compatible with --...
  - facabc1db378af42a7b0e600ce7af59f188e8786 fix: allow empty glob for `testdata` in the Gazelle exten...
  - 9c7c45b8760f860c480ca5feff342196957b7044 Update maintainer guide for bzlmod and bazel-central-regi...
  - 9cbe3aea11ef8834de8c85be5d8acb8dc2d0e7c8 Fix distribution tarballs and update changelog and versio...
  - 99a6bcb240e38495d45290a91357c41fd4821b61 Add gazelle plugin to CI and distribution mechanism (#424)
  - 5bfcb1a684550626ce138fe0fe8f5f702b3764c3 Stop registering a Go SDK in the Gazelle submodule (#411)
  - 60abca8fa2f970d4899857a46cb0586338dbf7a1 Add the gazelle plugin to the distribution (#400)
  - 8a6ab72c6ece96cab91e17aaf4fb5339615d1d3d Stop hardcoding runfiles prefix (#402)
  - bc112d41fd71a5abf51ff827f19a6af9ed81af43 Bump stardoc dep to unbreak build with --experimental_ena...
  - 61d9c6283308410d91f769e489e53855d446d995 Make settings error message more friendly (#394)
  - 908bf1431d276245ba921e37862f74cec45ba9f4 Allow sandboxing for copy_* and fix copy_directory tests ...
  - 42abf5cbf28a222b2b4d04f3396db13bc842fc33 Documentation fixes (#391)
  - c5ededc7e8f7dcf36f39ffa819ce4e38e59977cc Fix stardoc_with_diff_test linter warnings (#390)
  - 6a17363a3c27dde70ab5002ad9f2e29aff1e1f4b Update changelog and version for release 1.3.0 (#388)
  - d7e9dbb31fb41f2d4c5073cf2800e6f99e83d545 Add missing docs and doc links; update bazel.build links ...
  - 31ab4c8bd2386238ed204e8cd3c271c6eef601ef feat: bzlmod setup (#385)
  - 1bbb388780f6016b6981a2f075fb457e999bc3bd Update unittest_doc.md with analysistest and loadingtest ...
  - 69b4636956c55b620c0776f4262a38a15554169c Fix doc error for analystest.begin (#369)
  - c1dfc324fbac0d5e4da32a93a3cafb2dc8908a09 Fixing typo: allocate slice with the correct size (#383)
  - 872e9b06e18ae8ba2897cb65b9aaa172aa6279f3 Fix diff_test on Windows with --enable_runfiles --nolegac...
  - a501641daebdce8601ee6bbc6b5d177c688d3517 Use stricter execution requirements for copy actions (#372)
  - 207acb38505b4a4acde45521b8c1fe07c762537a Add copy_directory rule (#366)
  - 312bccd83b1364fa736dde97ccba3d2b40cdfabc Update doc review section of maintainer guide (#368)
  - a6f17ab1fec39a2d65d13bf3c6c79079237a53f7 Switch native_binary/test to use symlinks (#340)
  - a832b8d717c01e76ecfc28322873a44e12aa23bd copy_file: Do not add non-executables to default_runfiles...
  - 67bfa0ce4de5d4b512178d5f63abad1696f6c05b Switch run_binary to cfg = "exec" to fix buildifier failu...
  - d54e8a70ce90a24b921381cbe84fa0b88b22dc46 Remove unnecessary wrapper macro for expand_template rule...
  - de3035d605b4c89a62d6da060188e4ab0c5034b9 Properly shell-quote diff_test's failure_message in bash ...
  - 6abad3de5fd9c001f67b17fe8c7242b3cc3b8851 Build native_binary/test src in correct configuration (#3...
  - cc51024fc2305fbcdbd5a3af993e29e7859193d4 Add subpackages module to skylib to support new bazel nat...
  - 2a87d4a62af886fb320883aba102255aba87275e Add expand_template rule (#330)
  - b9ec2c2dbb38c17819bb3e26409029bd35d63ba5 Allow using python3 for timestamps on macOS and BSD (#362)
  - 8e2ba6e9df6f14799a1b91cb15c426a367bc8bd6 Fix runfiles in native_binary/native_test (#339)
  - bd79f922c9e307f7cd2a5179c957189e7bf185fb Add diff_test asserting that docs are up-to-date (#321)
  - b669088a950c6d0890baa82327b67975ed56658e Update dicts documentation. (#361)
  - 8334f938c1574ef6f1f7a38a03550a31df65274e Implement omit and pick dicts functions. (#304)
  - ee67264452174896741824ed25ade0f6d58ca642 Update changelog and version for release 1.2.1 (#360)
  - 898cd6ddffee2a29a013ae9b70411cfe0ad16268 Remove unused, empty //rules:bins filegroup, allowing us ...
  - 5bffd04256c07a935c884339b433ca9e1d5c9a8e Add a maintainer's guide (#356)
  - e30197f3799eb038fbed424e365573f493d52fa5 Extend owners of skylib. (#355)
  - c4dfec1bf1316ab4e9fffbb382cf48259e0944fb Update changelog and version for release 1.2.0 (#350)
  - cdd0afdfe63afedac43fd15c1d60bd23b2241e24 Fixed positional args for unittest targets (#352)
  - 2bc90bdf7dc9914d126cf8594c3838494fc00d19 Allow unit test rules to be documented (#343)
  - 7270e3b345371c1b6bbb65f5598dcac48b3593bd Add support for 'loading' unit tests, which evaluate a LO...
  - 1e1c324391d81b3c768e4a11e50106929953f348 Fix linter warnings with new buildifier version. (#349)
  - ecc11f9a4c06400d4797e7132e71fe8702490cf0 Fix name arg documentation for native_binary (#338)
  - 6e30a77347071ab22ce346b6d20cf8912919f644 Update internal dependencies to modern versions. Bazel Fe...
  - 8e923ca4b9c922420bf460f48f933e9efb4c88d2 Use more portable `#!/usr/bin/env bash` shebang instead o...
  - 506c17293ef4043c68f8cb0ba5fa05d758e1231a Improve escaping in unittest failure message (#320)
  - b2ed61686ebca2a44d44857fef5b3e1d31cc2483 Missing version number bump in version.bzl for the new re...
  - 50d2680f5f670ad887a4a43c8322827850a1e605 Update changelog for release 1.1.0 (#317)
  - eabe5f7fe9ad744f0074d61c65fb29dd3d228a68 Run regenerate_docs.sh (#297)
  - 43a545a67ea2b9673365745b1b5372170d730922 Make diff_test work on windows with --enable_runfiles (#3...
  - 14f17ae7f71f347b5e720fca55e33df40bc4e5d5 Windows support for build_test (#302)
  - 08398cdc99b2042dfb5748fd49ef8393b9045c8e Allow specifying additional aspects to tut (#299)
  - df3c9e2735f02a7fe8cd80db4db00fec8e13d25f diff_test: add ability for caller to specify a message pr...
  - 0c57e74606b4e87606b0a9164fbfa4947e89e29c Remove `$` from grep regexes (#311)
  - b053a5ae113fe48ecd100a0055fcdaa223d2253a Update partial.bzl to generate better markdown (#309)
  - 775f66fb282ba8e7f24a27994942c7fbb82163f0 Update partial_doc.md (#308)
  - fd75066f159234265efb8f838b056be5a2e00a59 update links to bazel docs (#306)
  - c6f6b5425b232baf5caecc3aae31d49d63ddec03 Fix default branch name in README (#292)
  - 7b859037a673db6f606661323e74c5d4751595e6 to_json/to_proto methods on structs are deprecated and wi...

BAZEL_SKYLIB_VERSION_REV_ID: 288731ef9f7f688932bd50e704a91a45ec185f9b
Change-Id: Id5bece2bb052172948dee5dd42e3373d50d649e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants