Update uarch detection for Intel processors #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toor1245
force-pushed
the
update-detection-intel-cpu
branch
2 times, most recently
from
720c0e0
to
547d168
Compare
|
@gchatelet, @Mizux, please review |
toor1245
commented
Oct 23, 2021
src/cpuinfo_x86.c
Outdated
| @@ -20,6 +20,7 @@ | |||
|
|
|||
| #include "internal/bit_utils.h" | |||
| #include "internal/cpuid_x86.h" | |||
| #include "internal/string_view.h" | |||
There was a problem hiding this comment.
added this line as CpuFeaturesStringView_CopyString doesn't work on Windows
There was a problem hiding this comment.
Can you rebase? I've fixed it in #187
toor1245
commented
Oct 23, 2021
src/cpuinfo_x86.c
Outdated
| @@ -1700,7 +1747,7 @@ void FillX86BrandString(char brand_string[49]) { | |||
| }; | |||
| const size_t leaves_size = sizeof(leaves); | |||
| #if __STDC_VERSION__ >= 201112L | |||
| _Static_assert(leaves_size == 48, "Leaves must be packed"); | |||
| _Static_assert(sizeof(leaves) == 48, "Leaves must be packed"); | |||
There was a problem hiding this comment.
I changed to sizeof(leaves) due to #185
|
Thx for the patch! Can you rebase? |
yes, sure |
toor1245
force-pushed
the
update-detection-intel-cpu
branch
2 times, most recently
from
5ac4bd0
to
390baec
Compare
|
@gchatelet, updated |
|
Do you mind if we push #194 first and rebase this patch afterward? |
yes, don't mind |
|
You can to import your changes in |
toor1245
force-pushed
the
update-detection-intel-cpu
branch
2 times, most recently
from
053f3d1
to
d5b5629
Compare
toor1245
force-pushed
the
update-detection-intel-cpu
branch
from
d5b5629
to
372e822
Compare
|
@gchatelet, updated |
|
Thx for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added detection: