Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add detection LZCNT #254

Merged
merged 2 commits into from
Jul 28, 2022
Merged

Add detection LZCNT #254

merged 2 commits into from
Jul 28, 2022

Conversation

toor1245
Copy link
Contributor

Mizux
Mizux reviewed Jul 22, 2022
View reviewed changes
src/impl_x86__base_implementation.inl Outdated
@@ -1755,6 +1757,7 @@ CacheInfo GetX86CacheInfo(void) {
LINE(X86_RDRND, rdrnd, , , ) \
LINE(X86_DCA, dca, , , ) \
LINE(X86_SS, ss, , , ) \
LINE(X86_LZCNT, lzcnt, , , ) \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit should be placed after ADX to be order consistent with the X86FeaturesEnum declaration

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, updated

@toor1245
Copy link
Contributor Author

ping @gchatelet

@gchatelet
Copy link
Collaborator

I missed the update, thx for the ping.

@gchatelet gchatelet merged commit 601471d into google:main Jul 28, 2022
@gchatelet gchatelet added this to the v0.8.0 milestone Apr 27, 2023
@gchatelet gchatelet added the enhancement New feature or request label Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mizux Mizux Mizux approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@toor1245 @gchatelet @Mizux