Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ENABLE_INSTALL option to manage 'install' target #325

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Add ENABLE_INSTALL option to manage 'install' target #325

merged 1 commit into from
Aug 31, 2023

Conversation

amitin
Copy link
Contributor

@amitin amitin commented Aug 30, 2023 •
edited by Mizux

Opening this in a replace for:

@amitin amitin mentioned this pull request Aug 30, 2023
Closed
@amitin amitin changed the title Add BUILD_INSTALL option to manage 'install' target Add ENABLE_INSTALL option to manage 'install' target Aug 30, 2023
Mizux
Mizux approved these changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@Mizux Mizux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mizux Mizux added cmake CMake related issue enhancement New feature or request labels Aug 30, 2023
@Mizux Mizux added this to the v0.9.0 milestone Aug 30, 2023
@gchatelet gchatelet merged commit 52874f0 into google:main Aug 31, 2023
29 checks passed
@gchatelet
Copy link
Collaborator

Thx for the PR @amitin !

@jdemel jdemel mentioned this pull request Sep 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mizux Mizux Mizux approved these changes

Assignees

@gchatelet gchatelet

@Mizux Mizux

Labels
cmake CMake related issue enhancement New feature or request
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@amitin @gchatelet @Mizux