Skip to content
This repository has been archived by the owner on Feb 11, 2024. It is now read-only.

Flutter support #18

Merged
merged 22 commits into from
Aug 4, 2021
Merged

Flutter support #18

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
cf87c48
flutter support: initial commit
unsuitable001 Jul 27, 2021
11e8c11
implement: android support
unsuitable001 Jul 27, 2021
d0ea739
CI: exclude flutter sample from dart analyze
unsuitable001 Jul 27, 2021
1b6a8a2
flutter: add linux support
unsuitable001 Jul 28, 2021
6094162
update tools/setup for android
unsuitable001 Jul 28, 2021
bafdd35
flutter: add windows support
unsuitable001 Jul 28, 2021
bd49741
update readme for android support
unsuitable001 Jul 28, 2021
875cc3a
str interpolate -> package:path join & adding constants
unsuitable001 Jul 29, 2021
a631548
remove circular ref in map
unsuitable001 Jul 29, 2021
0488e0e
make androidPath final
unsuitable001 Jul 29, 2021
2481e54
add flutter platform keys for desktops
unsuitable001 Aug 1, 2021
e0bdfb8
readme fixes and CI from Dart -> Flutter
unsuitable001 Aug 2, 2021
3870e67
update ci
unsuitable001 Aug 4, 2021
9fa8327
remove boilerplate widget_test
unsuitable001 Aug 4, 2021
edb24bd
ci check success on each step
unsuitable001 Aug 4, 2021
59da4ee
ci: remove successs check at wrong place
unsuitable001 Aug 4, 2021
3adf06f
change exit code in case of build failure
unsuitable001 Aug 4, 2021
3a4c1d7
remove linking with dart.lib (windows) and int -> size_t for strlen
unsuitable001 Aug 4, 2021
3dbaf29
add `flutter create` boilerplate modification notes
unsuitable001 Aug 4, 2021
d26ed08
Network -> network
unsuitable001 Aug 4, 2021
5c58ed6
yet another typo :sweat:
unsuitable001 Aug 4, 2021
4cdcc6c
change download url
unsuitable001 Aug 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions android/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="dev.google.cronet">
<!-- Flutter Boilerplate Modifications: Internet & Netwrok Permissions-->
unsuitable001 marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the another modified file that I mis-"copy pasted" with another manifest file's path.

<uses-permission android:name="android.permission.INTERNET" />
<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
</manifest>
2 changes: 2 additions & 0 deletions example/flutter/android/app/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you leave comments on what lines of the file were added/modified from the generated file? That way it will be easier to deal with conflicts etc. if the Flutter project needs to be updated in the future.

package="dev.google.cronet_example">
<!-- Flutter Boilerplate Modifications: Internet & Netwrok Permissions -->
<uses-permission android:name="android.permission.INTERNET" />
<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
<!-- Flutter Boilerplate Modifications: Enable Cleartext Traffic -->
<application
android:label="cronet_example"
android:icon="@mipmap/ic_launcher"
Expand Down