Migrate Essentials v0.0.1: Implement Client with openUrl method

README.md

@@ -88,7 +88,4 @@ dart run cronet <platform> # Downloads the cronet binaries.
 dart test --platform vm
 ```
 
-**Note:** Make sure that `52XX` ports are not reserved by any other process.
-As some of the tests use ports in this range.
-
 **Wrapper & Cronet binaries build guide**: [BUILD.md](lib/src/native/wrapper/BUILD.md)

test/http_client_close_test.dart

@@ -7,13 +7,15 @@ import 'dart:io';
 
 import 'package:cronet/cronet.dart';
 import 'package:test/test.dart';
+import 'test_utils.dart';
 
 void main() {
   group('client_close_test', () {
     late HttpServer server;
-    final sentData = 'Hello, world!';
+    late int port;
     setUp(() async {
-      server = await HttpServer.bind(InternetAddress.anyIPv6, 5253);
+      server = await HttpServer.bind(InternetAddress.anyIPv6, 0);
+      port = server.port;
       server.listen((HttpRequest request) {
         request.response.write(sentData);
         request.response.close();
@@ -25,14 +27,14 @@ void main() {
       client.close();
       expect(
           () async =>
-              await client.openUrl('GET', Uri.parse('http://localhost:5253')),
+              await client.openUrl('GET', Uri.parse('http://$host:$port')),
           throwsException);
     });
 
     test('Keeps the previous connection alive, if closed afterwards', () async {
       final client = HttpClient();
       final request =
-          await client.openUrl('GET', Uri.parse('http://localhost:5253'));
+          await client.openUrl('GET', Uri.parse('http://$host:$port'));
       final resp = await request.close();
       client.close();
       final dataStream = resp.transform(utf8.decoder);

test/http_request_exceptions_test.dart

@@ -6,33 +6,38 @@ import 'dart:io';
 
 import 'package:cronet/cronet.dart';
 import 'package:test/test.dart';
+import 'test_utils.dart';
 
 void main() {
   group('request_HttpException_test', () {
     late HttpClient client;
+    late int port;
     setUp(() async {
       client = HttpClient();
+      final server = await HttpServer.bind(InternetAddress.anyIPv6, 0);
+      port = server.port;
+      server.close();
     });
 
     test('URL do not exist', () async {
       final request = await client.openUrl('GET',
-          Uri.parse('http://localghost:9999')); // localghost shouln't exist :p
+          Uri.parse('http://localghost:$port')); // localghost shouln't exist :p
       final resp = await request.close();
       expect(resp,
           emitsInOrder(<Matcher>[emitsError(isA<HttpException>()), emitsDone]));
     });
 
     test('The port is wrong', () async {
       final request = await client.openUrl('GET',
-          Uri.parse('http://localhost:9999')); // port 9999 should be close
+          Uri.parse('http://$host:$port')); // port 9999 should be close
       final resp = await request.close();
       expect(resp,
           emitsInOrder(<Matcher>[emitsError(isA<HttpException>()), emitsDone]));
     });
 
     test('The scheme is wrong', () async {
       final request =
-          await client.openUrl('GET', Uri.parse('random://localhost:5253'));
+          await client.openUrl('GET', Uri.parse('random://$host:$port'));
       final resp = await request.close();
       expect(resp,
           emitsInOrder(<Matcher>[emitsError(isA<HttpException>()), emitsDone]));

test/http_responses_exceptions_test.dart

@@ -6,14 +6,17 @@ import 'dart:io';
 
 import 'package:cronet/cronet.dart';
 import 'package:test/test.dart';
+import 'test_utils.dart';
 
 void main() {
   group('response_HttpException_test', () {
     late HttpClient client;
     late HttpServer server;
+    late int port;
     setUp(() async {
       client = HttpClient();
-      server = await HttpServer.bind(InternetAddress.anyIPv6, 5255);
+      server = await HttpServer.bind(InternetAddress.anyIPv6, 0);
+      port = server.port;
       server.listen((HttpRequest request) {
         final paths = request.uri.pathSegments;
         request.response.statusCode = int.parse(paths[0]);
@@ -23,7 +26,7 @@ void main() {
 
     test('404, Not Found', () async {
       final request =
-          await client.getUrl(Uri.parse('http://localhost:5255/404'));
+          await client.getUrl(Uri.parse('http://$host:$port/404'));
       final resp = await request.close();
       expect(
           resp,
@@ -36,7 +39,7 @@ void main() {
 
     test('401, Unauthorized', () async {
       final request =
-          await client.getUrl(Uri.parse('http://localhost:5255/401'));
+          await client.getUrl(Uri.parse('http://$host:$port/401'));
       final resp = await request.close();
       expect(
           resp,
@@ -49,7 +52,7 @@ void main() {
 
     test('503, Service Unavailable', () async {
       final request =
-          await client.getUrl(Uri.parse('http://localhost:5255/503'));
+          await client.getUrl(Uri.parse('http://$host:$port/503'));
       final resp = await request.close();
       expect(
           resp,
@@ -64,7 +67,7 @@ void main() {
 
     test('New API: 503, Service Unavailable', () async {
       final request =
-          await client.getUrl(Uri.parse('http://localhost:5255/503'));
+          await client.getUrl(Uri.parse('http://$host:$port/503'));
       final success = await request.registerCallbacks(
           (data, bytesRead, responseCode) {}, onFailed: (reason) {
         expect(

test/http_responses_new_api_test.dart

@@ -7,15 +7,17 @@ import 'dart:io';
 
 import 'package:cronet/cronet.dart';
 import 'package:test/test.dart';
+import 'test_utils.dart';
 
 void main() {
   group('callback_api_response_test New API', () {
     late HttpClient client;
     late HttpServer server;
-    final sentData = 'Hello, world!';
+    late int port;
     setUp(() async {
       client = HttpClient();
-      server = await HttpServer.bind(InternetAddress.anyIPv6, 5256);
+      server = await HttpServer.bind(InternetAddress.anyIPv6, 0);
+      port = server.port;
       server.listen((HttpRequest request) {
         if (request.uri.pathSegments.isNotEmpty &&
             request.uri.pathSegments[0] == '301') {
@@ -30,7 +32,7 @@ void main() {
 
     test('Gets Hello, world response from server using getUrl', () async {
       String resp = '';
-      final request = await client.getUrl(Uri.parse('http://localhost:5256'));
+      final request = await client.getUrl(Uri.parse('http://$host:$port'));
       final success =
           await request.registerCallbacks((data, bytesRead, responseCode) {
         resp += utf8.decoder.convert(data);
@@ -44,7 +46,7 @@ void main() {
     test('Invalid URLs calls onFailed and returns false', () async {
       String resp = '';
       final request = await client.getUrl(
-          Uri.parse('http://localghost:5256')); // localghost shouldn't exist
+          Uri.parse('http://localghost:$port')); // localghost shouldn't exist
       final success =
           await request.registerCallbacks((data, bytesRead, responseCode) {
         resp += utf8.decoder.convert(data);
@@ -58,21 +60,21 @@ void main() {
     test('URL redirect on 301 and fetch data', () async {
       String resp = '';
       final request =
-          await client.getUrl(Uri.parse('http://localhost:5256/301'));
+          await client.getUrl(Uri.parse('http://$host:$port'));
       final success =
           await request.registerCallbacks((data, bytesRead, responseCode) {
         resp += utf8.decoder.convert(data);
       }, onRedirectReceived: (location, responseCode) {
         expect(responseCode, equals(301));
-        expect(location, equals('http://localhost:5256/'));
+        expect(location, equals('http://$host:$port'));
       });
       expect(resp, equals(sentData));
       expect(success, equals(true));
     });
 
     test('registering callbacks after response.close will throw error',
         () async {
-      final request = await client.getUrl(Uri.parse('http://localhost:5256'));
+      final request = await client.getUrl(Uri.parse('http://$host:$port'));
       await request.close();
       expect(request.registerCallbacks((data, bytesRead, responseCode) {}),
           throwsA(isA<ResponseListenerException>()));

test/http_responses_test.dart

@@ -7,15 +7,17 @@ import 'dart:io';
 
 import 'package:cronet/cronet.dart';
 import 'package:test/test.dart';
+import 'test_utils.dart';
 
 void main() {
   group('http_responses_test', () {
     late HttpClient client;
     late HttpServer server;
-    final sentData = 'Hello, world!';
+    late int port;
     setUp(() async {
       client = HttpClient();
-      server = await HttpServer.bind(InternetAddress.anyIPv6, 5252);
+      server = await HttpServer.bind(InternetAddress.anyIPv6, 0);
+      port = server.port;
       server.listen((HttpRequest request) {
         if (request.method == 'CUSTOM') {
           request.response.write(request.method);
@@ -27,14 +29,14 @@ void main() {
     });
 
     test('Gets Hello, world response from server using getUrl', () async {
-      final request = await client.getUrl(Uri.parse('http://localhost:5252'));
+      final request = await client.getUrl(Uri.parse('http://$host:$port'));
       final resp = await request.close();
       final dataStream = resp.transform(utf8.decoder);
       expect(dataStream, emitsInOrder(<Matcher>[equals(sentData), emitsDone]));
     });
 
     test('Gets Hello, world response from server using get method', () async {
-      final request = await client.get('localhost', 5252, '/');
+      final request = await client.get(host, port, '/');
       final resp = await request.close();
       final dataStream = resp.transform(utf8.decoder);
       expect(dataStream, emitsInOrder(<Matcher>[equals(sentData), emitsDone]));
@@ -43,7 +45,7 @@ void main() {
     test('Gets Hello, world response from server using openUrl method',
         () async {
       final request =
-          await client.openUrl('GET', Uri.parse('http://localhost:5252'));
+          await client.openUrl('GET', Uri.parse('http://$host:$port'));
       final resp = await request.close();
       final dataStream = resp.transform(utf8.decoder);
       expect(dataStream, emitsInOrder(<Matcher>[equals(sentData), emitsDone]));
@@ -53,23 +55,23 @@ void main() {
         'Fetch Hello, world response from server using openUrl, custom method method',
         () async {
       final request =
-          await client.openUrl('CUSTOM', Uri.parse('http://localhost:5252'));
+          await client.openUrl('CUSTOM', Uri.parse('http://$host:$port'));
       final resp = await request.close();
       final dataStream = resp.transform(utf8.decoder);
       expect(dataStream, emitsInOrder(<Matcher>[equals('CUSTOM'), emitsDone]));
     });
 
     test('Fetch Hello, world response from server using POST request',
         () async {
-      final request = await client.postUrl(Uri.parse('http://localhost:5252'));
+      final request = await client.postUrl(Uri.parse('http://$host:$port'));
       final resp = await request.close();
       final dataStream = resp.transform(utf8.decoder);
       expect(dataStream, emitsInOrder(<Matcher>[equals(sentData), emitsDone]));
     });
 
     test('response.close after registering callbacks will throw error',
         () async {
-      final request = await client.postUrl(Uri.parse('http://localhost:5252'));
+      final request = await client.postUrl(Uri.parse('http://$host:$port'));
       request.registerCallbacks((data, bytesRead, responseCode) {});
       expect(request.close(), throwsA(isA<ResponseListenerException>()));
     });

test/test_utils.dart

@@ -0,0 +1,2 @@
+const host = 'localhost';
+const sentData = 'Hello, world!';