Skip to content

Commit

Permalink
Upgrade Dagger's dependencies of kotlin to 1.9.20 and ksp to `1.9.2…
Browse files Browse the repository at this point in the history
…0-1.0.14`.

This should bring in a number of fixes in KSP, especially related to incremental processing.

Fixes #4060

RELNOTES=Upgrade Dagger's dependencies of kotlin to `1.9.20` and ksp to `1.9.20-1.0.14`.
PiperOrigin-RevId: 586435985
  • Loading branch information
bcorso authored and Dagger Team committed Nov 29, 2023
1 parent cd70dea commit 692015f
Show file tree
Hide file tree
Showing 12 changed files with 20 additions and 19 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Expand Up @@ -13,9 +13,9 @@ env:
USE_JAVA_VERSION: '11'
# This is required by AGP 8.3+.
USE_JAVA_VERSION_FOR_PLUGIN: '17'
# Our Bazel builds currently rely on 6.3.2. The version is set via
# Our Bazel builds currently rely on 6.4.0. The version is set via
# baselisk by USE_BAZEL_VERSION: https://github.com/bazelbuild/bazelisk.
USE_BAZEL_VERSION: '6.3.2'
USE_BAZEL_VERSION: '6.4.0'
# The default Maven 3.9.0 has a regression so we manually install 3.8.7.
# https://issues.apache.org/jira/browse/MNG-7679
USE_MAVEN_VERSION: '3.8.7'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Expand Up @@ -12,9 +12,9 @@ env:
USE_JAVA_VERSION: '11'
# This is required by AGP 8.3+.
USE_JAVA_VERSION_FOR_PLUGIN: '17'
# Our Bazel builds currently rely on 6.3.2. The version is set via
# Our Bazel builds currently rely on 6.4.0. The version is set via
# baselisk by USE_BAZEL_VERSION: https://github.com/bazelbuild/bazelisk.
USE_BAZEL_VERSION: '6.3.2'
USE_BAZEL_VERSION: '6.4.0'
DAGGER_RELEASE_VERSION: "${{ github.event.inputs.dagger_release_version }}"
# The default Maven 3.9.0 has a regression so we manually install 3.8.7.
# https://issues.apache.org/jira/browse/MNG-7679
Expand Down
6 changes: 3 additions & 3 deletions WORKSPACE
Expand Up @@ -119,10 +119,10 @@ http_archive(

load("@io_bazel_rules_kotlin//kotlin:repositories.bzl", "kotlin_repositories", "kotlinc_version")

KOTLIN_VERSION = "1.9.0"
KOTLIN_VERSION = "1.9.20"

# Get from https://github.com/JetBrains/kotlin/releases/
KOTLINC_RELEASE_SHA = "1fc50d805f9809e92de43e91f089cc8618567c1a350faebdabf8a40c5048bee8"
KOTLINC_RELEASE_SHA = "15a8a2825b74ccf6c44e04e97672db802d2df75ce2fbb63ef0539bf3ae5006f0"

kotlin_repositories(
compiler_release = kotlinc_version(
Expand Down Expand Up @@ -171,7 +171,7 @@ CHECKER_FRAMEWORK_VERSION = "2.5.3"

ERROR_PRONE_VERSION = "2.14.0"

KSP_VERSION = KOTLIN_VERSION + "-1.0.12"
KSP_VERSION = KOTLIN_VERSION + "-1.0.14"

maven_install(
artifacts = [
Expand Down
4 changes: 2 additions & 2 deletions java/dagger/hilt/android/plugin/build.gradle
@@ -1,8 +1,8 @@
buildscript {
ext {
kotlin_version = "1.9.0"
kotlin_version = "1.9.20"
agp_version = System.getenv('AGP_VERSION') ?: "7.2.0"
ksp_version = "$kotlin_version-1.0.12"
ksp_version = "$kotlin_version-1.0.14"
pluginArtifactId = 'hilt-android-gradle-plugin'
pluginId = 'com.google.dagger.hilt.android'
}
Expand Down
Binary file modified java/dagger/internal/codegen/xprocessing/xprocessing-testing.jar
Binary file not shown.
Binary file modified java/dagger/internal/codegen/xprocessing/xprocessing.jar
Binary file not shown.
4 changes: 2 additions & 2 deletions javatests/artifacts/dagger-android-ksp/build.gradle
Expand Up @@ -17,8 +17,8 @@
buildscript {
ext {
agp_version = "8.1.0"
kotlin_version = "1.9.0"
ksp_version = "$kotlin_version-1.0.12"
kotlin_version = "1.9.20"
ksp_version = "$kotlin_version-1.0.14"
}
repositories {
google()
Expand Down
5 changes: 3 additions & 2 deletions javatests/artifacts/dagger-ksp/build.gradle
Expand Up @@ -17,8 +17,8 @@
buildscript {
ext {
dagger_version = "LOCAL-SNAPSHOT"
kotlin_version = "1.9.0"
ksp_version = "$kotlin_version-1.0.12"
kotlin_version = "1.9.20"
ksp_version = "$kotlin_version-1.0.14"
junit_version = "4.13"
truth_version = "1.0.1"
}
Expand All @@ -27,6 +27,7 @@ buildscript {
mavenLocal()
}
dependencies {
classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version")
classpath("com.google.devtools.ksp:com.google.devtools.ksp.gradle.plugin:$ksp_version")
}
}
Expand Down
4 changes: 2 additions & 2 deletions javatests/artifacts/dagger/build.gradle
Expand Up @@ -17,8 +17,8 @@
buildscript {
ext {
dagger_version = "LOCAL-SNAPSHOT"
kotlin_version = "1.9.0"
ksp_version = "$kotlin_version-1.0.12"
kotlin_version = "1.9.20"
ksp_version = "$kotlin_version-1.0.14"
junit_version = "4.13"
truth_version = "1.0.1"
}
Expand Down
2 changes: 1 addition & 1 deletion javatests/artifacts/hilt-android/simple/build.gradle
Expand Up @@ -17,7 +17,7 @@
buildscript {
ext {
dagger_version = 'LOCAL-SNAPSHOT'
kotlin_version = '1.9.0'
kotlin_version = '1.9.20'
agp_version = System.getenv('AGP_VERSION') ?: "7.1.2"
}
repositories {
Expand Down
4 changes: 2 additions & 2 deletions javatests/artifacts/hilt-android/simpleKotlin/build.gradle
Expand Up @@ -16,8 +16,8 @@

buildscript {
ext {
kotlin_version = '1.9.0'
ksp_version = "$kotlin_version-1.0.12"
kotlin_version = '1.9.20'
ksp_version = "$kotlin_version-1.0.14"
agp_version = System.getenv('AGP_VERSION') ?: "7.1.2"
}
repositories {
Expand Down
2 changes: 1 addition & 1 deletion javatests/artifacts/hilt-android/viewmodel/build.gradle
Expand Up @@ -19,7 +19,7 @@ buildscript {
hilt_version = 'LOCAL-SNAPSHOT'
// AGP is set below 7.2.0 on purpose to be able to obfuscate debug apk.
agp_version = "7.1.2"
kotlin_version = '1.9.0'
kotlin_version = '1.9.20'
}
repositories {
google()
Expand Down

0 comments on commit 692015f

Please sign in to comment.