-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependencies should be allowed to have multiple qualifier annotations. #201
Comments
JSR330 forbids this. On Sun, May 31, 2015, 1:04 PM John-Paul Cunliffe notifications@github.com
|
That ... is unfortunate. Are annotation compositions allowed? |
You can put explicit combinations together in a specific new annotation's On Sun, May 31, 2015, 2:01 PM John-Paul Cunliffe notifications@github.com
|
I had a feeling you would say that. I can see how this spec simplifies qualifiers, but it still feels inappropriately limiting. In any case, this issue can be closed. |
This is incorrect, from the JSR-330
This states that no more than one qualifier should annotate a single field or parameter if you want to remain injector-independent. The wording was specifically changed to allow for multiple qualifiers as long as users understand that this means they might be tied to a specific injector implementation. See discussion here, last few comments: https://code.google.com/archive/p/atinject/issues/2 |
Shall we reopen then? |
Would you consider merging a well written+tested pull request, allowing dependencies to have multiple qualifier annotations? Are there any plans that I would need to be aware of before starting?
The text was updated successfully, but these errors were encountered: