Optimize BindingGraph.create() by indexing all binding nodes by their component path instead of traversing the full network for each subcomponent. #2446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_360362601
branch
2 times, most recently
from
5506a64
to
9ea7a9a
Compare
… component path instead of traversing the full network for each subcomponent. The traversals maintain sets of visited nodes, which aren't great for hashing. Network.successors() is also not well optimized, so repeating that is costly. RELNOTES=Build performance improvements PiperOrigin-RevId: 361390045
copybara-service
bot
force-pushed
the
test_360362601
branch
from
9ea7a9a
to
47123ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize BindingGraph.create() by indexing all binding nodes by their component path instead of traversing the full network for each subcomponent.
The traversals maintain sets of visited nodes, which aren't great for hashing. Network.successors() is also not well optimized, so repeating that is costly.
RELNOTES=Build performance improvements