Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize BindingGraph.create() by indexing all binding nodes by their component path instead of traversing the full network for each subcomponent. #2446

Merged
merged 1 commit into from Mar 7, 2021
Merged

Optimize BindingGraph.create() by indexing all binding nodes by their component path instead of traversing the full network for each subcomponent. #2446

merged 1 commit into from Mar 7, 2021

Commits on Mar 7, 2021

  1. Optimize BindingGraph.create() by indexing all binding nodes by their… 

    … component path instead of traversing the full network for each subcomponent.

The traversals maintain sets of visited nodes, which aren't great for hashing. Network.successors() is also not well optimized, so repeating that is costly.

RELNOTES=Build performance improvements
PiperOrigin-RevId: 361390045
    @ronshapiro
    ronshapiro authored and Dagger Team committed Mar 7, 2021
    Configuration menu
    Copy the full SHA
    47123ec View commit details
    Browse the repository at this point in the history