Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dagger should fail when overriding hardcoded method names #2575

Closed
vRallev opened this issue Apr 23, 2021 · 0 comments
Closed

Dagger should fail when overriding hardcoded method names #2575

vRallev opened this issue Apr 23, 2021 · 0 comments

Comments

@vRallev
Copy link

vRallev commented Apr 23, 2021

Dagger generates a builder() method for components by default. This can lead to surprising results when the same method name in a component for a subcomponent builder is used:

@Component
interface ParentComponent {
  public fun builder(): MySubcomponent.Builder
}

In this case Dagger should throw an error and claim that method name.

copybara-service bot pushed a commit that referenced this issue Jul 1, 2021
…actory methods.

Fixes #2575

RELNOTES=Check if user added methods have same method signature as generated factory methods.
PiperOrigin-RevId: 379851182
copybara-service bot pushed a commit that referenced this issue Jul 1, 2021
…actory methods.

Fixes #2575

RELNOTES=Check if user added methods have same method signature as generated factory methods.
PiperOrigin-RevId: 379851182
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants