Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build warning: dagger.lint.DaggerIssueRegistry does not specify a vendor #2582

Closed
bubenheimer opened this issue Apr 28, 2021 · 8 comments
Closed
Assignees

Comments

@bubenheimer
Copy link

Building with Dagger 2.35.1, Gradle 7.0, AGP 7.0.0-alpha14 I see warnings:

Task :app:lintAnalyzeDebug

dagger.lint.DaggerIssueRegistry in /Users/me/.gradle/caches/transforms-3/d0ee303d2fb2dbd304a5fff6d69d1127/transformed/jetified-dagger-lint-aar-2.35.1/jars/lint.jar does not specify a vendor; see IssueRegistry#vendor

This likely existed in prior versions, I just had not looked into it.

Would be nice if these could be eliminated, I see a bunch of these for different modules. Thanks.

@danysantiago
Copy link
Member

Thanks - I think we might need to update our lint-api dependency to declare a vendor property in our IssueRegistry but should be easy to do.

@danysantiago danysantiago self-assigned this Apr 28, 2021
copybara-service bot pushed a commit that referenced this issue May 21, 2021
Also update the api since we are also updating the lint-api dependency.

Fixes: #2582
RELNOTES=Updates dagger-lint to avoid displaying a warning due to missing Vendor information.
PiperOrigin-RevId: 375004213
@ZacSweers
Copy link

Anything preventing #2639 from being merged now that AGP 7 stable is out?

copybara-service bot pushed a commit that referenced this issue Aug 12, 2021
Also update the api since we are also updating the lint-api dependency.

Fixes: #2582
RELNOTES=Updates dagger-lint to avoid displaying a warning due to missing Vendor information.
PiperOrigin-RevId: 375004213
@danysantiago
Copy link
Member

There is, the test which uses LintDetectorTest started to fail because there seems to be a requirement of absolute path dependencies:

java.lang.IllegalArgumentException: Relative Path found: ../maven/v1/https/repo1.maven.org/maven2/org/jetbrains/kotlin/kotlin-stdlib-jdk7/1.5.20/kotlin-stdlib-jdk7-1.5.20.jar. All paths should be absolute.
	at com.android.tools.lint.LintCliClient.initializeProjects(LintCliClient.kt:1346)
	at com.android.tools.lint.client.api.LintClient.performInitializeProjects$lint_api(LintClient.kt:1012)
	at com.android.tools.lint.client.api.LintDriver.initializeProjectRoots(LintDriver.kt:569)
	at com.android.tools.lint.client.api.LintDriver.doAnalyze(LintDriver.kt:484)
	at com.android.tools.lint.client.api.LintDriver.doAnalyze$default(LintDriver.kt:473)
	at com.android.tools.lint.client.api.LintDriver.analyze(LintDriver.kt:417)
	at com.android.tools.lint.checks.infrastructure.TestLintClient.analyze(TestLintClient.java:671)
	at com.android.tools.lint.checks.infrastructure.TestLintClient.analyze(TestLintClient.java:602)
	at com.android.tools.lint.checks.infrastructure.TestLintClient.checkLint(TestLintClient.java:349)
	at com.android.tools.lint.checks.infrastructure.TestLintRunner.checkLint(TestLintRunner.kt:229)
	at com.android.tools.lint.checks.infrastructure.TestLintRunner.run(TestLintRunner.kt:172)
	at com.android.tools.lint.checks.infrastructure.TestLintTask.run(TestLintTask.java:933)
	at dagger.lint.DaggerKotlinIssueDetectorTest.simpleSmokeTestForQualifiersAndProviders(DaggerKotlinIssueDetectorTest.kt:186)

I'll check with Lint team (a.k.a Tor) to see what we can do...

@danysantiago
Copy link
Member

Alright, the LintDetectorTest is fixed, but now there is a concern regarding this new API usage. Specifically users in AGP below 7.0 will have errors because the Vendor class will be loaded and fail to do so because their AGP + Lint version does not contain it, so we might have to hold off on actually adding this until 7.0 is more widely adopted. =/

@G00fY2
Copy link

G00fY2 commented Nov 10, 2021

APG 7 stable is now available for 106 days. Any plans to address this issue soon? I can imagine that people who keep dagger up-to-date also take care of switching to the latest AGP.

@Berki2021
Copy link

Any new info on this?? WHAT TO DO?

copybara-service bot pushed a commit that referenced this issue Feb 2, 2022
Also update the api since we are also updating the lint-api dependency.

Fixes: #2582
Fixes: //third_party/java_src/dagger/project/java/dagger/lint:lint-artifact-lib
RELNOTES=Updates dagger-lint to avoid displaying a warning due to missing Vendor information.
PiperOrigin-RevId: 375004213
copybara-service bot pushed a commit that referenced this issue Feb 2, 2022
Also update the api since we are also updating the lint-api dependency.

Fixes: #2582
Fixes: //third_party/java_src/dagger/project/java/dagger/lint:lint-artifact-lib
RELNOTES=Updates dagger-lint to avoid displaying a warning due to missing Vendor information.
PiperOrigin-RevId: 375004213
copybara-service bot pushed a commit that referenced this issue Feb 2, 2022
Also update the api since we are also updating the lint-api dependency.

Fixes: #2582
Fixes: //third_party/java_src/dagger/project/java/dagger/lint:lint-artifact-lib
RELNOTES=Updates dagger-lint to avoid displaying a warning due to missing Vendor information.
PiperOrigin-RevId: 375004213
copybara-service bot pushed a commit that referenced this issue Feb 7, 2022
Fixes: #2582
RELNOTES=Updates dagger-lint to avoid displaying a warning due to missing Vendor information.
PiperOrigin-RevId: 425932131
@liutikas
Copy link

Which version of Dagger is expected to have the fix?

@danysantiago
Copy link
Member

Version 2.41 and onwards should contain the fix for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants