-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge change from google internal #115
Merge change from google internal #115
Commits on Feb 4, 2015
-
Fix bug in ClassName.fromClass which causes an infinite loop if you p…
…ass it a nested class. ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=84557991
Configuration menu - View commit details
-
Copy full SHA for 3500539 - Browse repository at this point
Copy the full SHA 3500539View commit details -
Comment out javawriter pending migration to javapoet (it's left there…
… essentially as a todo), and depend on the released auto-value. ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=84571281
Configuration menu - View commit details
-
Copy full SHA for 2a0f0c6 - Browse repository at this point
Copy the full SHA 2a0f0c6View commit details -
Fix dependency request formatting so that it prints out resolved meth…
…ods & parameters. With support for implicit generic types, this otherwise printed out the unresolved methods/parameters, and was confusing. In fixing this, I also cleaned up the general listing of the dependency chain so that variables aren't suffixed with '()', and so that raw types are skipped (since they're synthetic dependencies due to the way members injectors are implemented, not real things that folks care about). ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=84577408
Configuration menu - View commit details
-
Copy full SHA for 475a606 - Browse repository at this point
Copy the full SHA 475a606View commit details -
Add support for subclassing modules to specify generic types. In the …
…process, clean up general support for subclassing modules & add a lot of validation. The rules are: a) Modules may be subclasses and may be subclassed. b) @module(includes) from parent classes are unioned into the child's dependencies. c) @provides methods may not be overridden or override another method. d) Modules referenced by @module(includes) must not be abstract. e) Modules referenced by @module(includes) must have the same @module annotation. f) @component(modules) must not be abstract. g) If a Module has type parameters, it must be abstract. (None of this validation existed before, though some of it should have.) ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=84582926
Configuration menu - View commit details
-
Copy full SHA for 0d49be8 - Browse repository at this point
Copy the full SHA 0d49be8View commit details -
Add lookup of ProductionBindings to BindingGraph.
------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=84670820
Configuration menu - View commit details
-
Copy full SHA for ca9c82b - Browse repository at this point
Copy the full SHA ca9c82bView commit details -
Fix NPE when map bindings are used without producers, and added corre…
…sponding functional test. ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=84696369
Configuration menu - View commit details
-
Copy full SHA for 69667a2 - Browse repository at this point
Copy the full SHA 69667a2View commit details -
Add a method to MoreTypes that does the same operation as Types.asEle…
…ment, but can be called statically. Then, clean up all of the places that callers to MoreTypes.asTypeElement were passing through a Types instance just for that reason. ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=84753119
Configuration menu - View commit details
-
Copy full SHA for cc08719 - Browse repository at this point
Copy the full SHA cc08719View commit details -
Make
@Component
a runtime-retained annotation, which can allow more…… interoperability with Guice. ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=84836495
Configuration menu - View commit details
-
Copy full SHA for e33a27c - Browse repository at this point
Copy the full SHA e33a27cView commit details -
Remove the Guava dependency from the Dagger functional tests. The tes…
…t now ensures that Dagger does not generate any code that uses Guava. ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=84889646
Configuration menu - View commit details
-
Copy full SHA for e78eb21 - Browse repository at this point
Copy the full SHA e78eb21View commit details -
Add producers functional tests.
------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=84889738
Configuration menu - View commit details
-
Copy full SHA for 36acd6a - Browse repository at this point
Copy the full SHA 36acd6aView commit details -
Produce sane error messages if for members injection requests of raw …
…types or unbounded types. In a better world, I would analyze the required dependencies of the members injected type (and its superclass' dependencies) and allow raw or unbounded parameters if none of the parameters were used as actual dependencies. Unfortunately, that's really hard to get right. So might as well fail with a sane error message for now until someone gets around to doing it better. ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=85010484
Configuration menu - View commit details
-
Copy full SHA for a5bf53f - Browse repository at this point
Copy the full SHA a5bf53fView commit details -
Allow dagger @component interfaces to depend upon interfaces which ar…
…e not themselves @component interfaces. ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=85067567
Configuration menu - View commit details
-
Copy full SHA for 56f8f00 - Browse repository at this point
Copy the full SHA 56f8f00View commit details -
An initial implementation of @subcomponent. It elides validation, so …
…it's a "use at your own risk" feature, but that is forthcoming. ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=85091489
1Configuration menu - View commit details
-
Copy full SHA for 959f5cd - Browse repository at this point
Copy the full SHA 959f5cdView commit details -
Add static analysis @nullable checks. Injected parameters that aren't…
… marked @nullable cannot by injected by an @provides or component method that has @nullable. Also generate null-checks in provision factories & component factories if they aren't @nullable. This can be controlled by a "dagger.nullableValidation={ERROR,WARNING}" flag, with the default being ERROR. WARNING will cause compilation to produce warnings when there's a nullable mismatch, and will ignore null return values from providers/component methods. ERROR will trigger the new behavior. This also changes compile-testing to support passing options to the compiler. ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=85151739
Configuration menu - View commit details
-
Copy full SHA for 725e783 - Browse repository at this point
Copy the full SHA 725e783View commit details -
Implement basic component generation for producers.
------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=85157486
Configuration menu - View commit details
-
Copy full SHA for 905358f - Browse repository at this point
Copy the full SHA 905358fView commit details -
Enable subcomponents of subcomponents (in addition to components).
------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=85180709
Configuration menu - View commit details
-
Copy full SHA for cd57feb - Browse repository at this point
Copy the full SHA cd57febView commit details -
Change the default dagger.nullableValidation to ERROR.
Explicitly mark [] to use WARNING, since they're full of errors. Global TAP looks pretty happy: [] ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=85283950
Configuration menu - View commit details
-
Copy full SHA for e2e97ad - Browse repository at this point
Copy the full SHA e2e97adView commit details -
Fix handling of dependencies attribute of ProductionComponent.
------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=85435991
Configuration menu - View commit details
-
Copy full SHA for abb9ea8 - Browse repository at this point
Copy the full SHA abb9ea8View commit details -
Fix @ProductionComponent depending on @ProductionComponent. The inter…
…face for Producer<T> has a ListenableFuture<T> get() method but the codegen was creating a T get() method. ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=85519772
Configuration menu - View commit details
-
Copy full SHA for 307126b - Browse repository at this point
Copy the full SHA 307126bView commit details
Commits on Feb 5, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 627a521 - Browse repository at this point
Copy the full SHA 627a521View commit details -
Cause the functional tests to use Java7 syntax, since they do. We nee…
…d to figure out if we want to revert that and force the functional tests back to 1.6, or just leave it, since the functionality isn't any different.
Configuration menu - View commit details
-
Copy full SHA for 847e2ae - Browse repository at this point
Copy the full SHA 847e2aeView commit details