Respect dagger.formatGeneratedSource in AndroidProcessor
#3532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chang-Eric
reviewed
Aug 16, 2022
| @@ -53,10 +53,17 @@ | |||
| public final class AndroidProcessor extends BasicAnnotationProcessor { | |||
| private static final String FLAG_EXPERIMENTAL_USE_STRING_KEYS = | |||
| "dagger.android.experimentalUseStringKeys"; | |||
| private static final String FLAG_FORMAT_GENERATED_SOURCES = | |||
| "dagger.formatGeneratedSource"; | |||
There was a problem hiding this comment.
I just noticed that this is reading a Dagger flag from Dagger Android. While not the worst thing, it is something I think we want to try to avoid as we try to keep them as separate as possible. I'm thinking of instead just removing the formatting entirely, especially since in Hilt we don't try to format our generated sources at all. Would this satisfy your use case? I assume you want this flag just to turn it off entirely?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3531