Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moe sync #605

Merged
merged 1 commit into from
Mar 2, 2017
Merged

Moe sync #605

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions android.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,13 +137,14 @@ The classes in [`dagger.android`] offer one approach to simplify this pattern.
```

5. Finally, in your `Activity.onCreate()` method, call
[`AndroidInjection.inject(this)`][AndroidInjection.inject(Activity)]:
[`AndroidInjection.inject(this)`][AndroidInjection.inject(Activity)] *before*
calling `super.onCreate();`:

```java
public class YourActivity extends Activity {
public void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
AndroidInjection.inject(this);
super.onCreate(savedInstanceState);
}
}
```
Expand Down Expand Up @@ -185,8 +186,8 @@ public class YourActivity extends Activity

@Override
public void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
AndroidInjection.inject(this);
super.onCreate(savedInstanceState);
// ...
}

Expand All @@ -201,8 +202,8 @@ public class YourFragment extends Fragment {

@Override
public void onAttach(Activity activity) {
super.onAttach(activity);
AndroidInjection.inject(this);
super.onAttach(activity);
// ...
}
}
Expand Down Expand Up @@ -255,10 +256,17 @@ Constructor injection is preferred whenever possible because `javac` will ensure
that no field is referenced before it has been set, which helps avoid
`NullPointerException`s. When members injection is required (as discussed
above), prefer to inject as early as possible. For this reason, `DaggerActivity`
calls `AndroidInjection.inject()` directly after `super.onCreate()`, and
`DaggerFragment` does the same in `super.onAttach()`, which also prevents
calls `AndroidInjection.inject()` immediately in `onCreate()`, before calling `super.onCreate()`, and
`DaggerFragment` does the same in `onAttach()`, which also prevents
inconsistencies if the `Fragment` is reattached.

It is crucial to call `AndroidInjection.inject()` before `super.onCreate()` in
an `Activity`, since the call to `super` attaches `Fragment`s from the previous
activity instance during configuration change, which in turn injects the
`Fragment`s. In order for the `Fragment` injection to succeed, the `Activity`
must already be injected. For users of [ErrorProne], it is a
compiler error to call `AndroidInjection.inject()` after `super.onCreate()`.

<!-- References -->

[AndroidInjection.inject(Activity)]: https://google.github.io/dagger/api/latest/dagger/android/AndroidInjection.html#inject-Activity-
Expand All @@ -270,6 +278,7 @@ inconsistencies if the `Fragment` is reattached.
[DaggerFragment]: https://google.github.io/dagger/api/latest/dagger/android/DaggerFragment.html
[DispatchingAndroidInjector]: https://google.github.io/dagger/api/latest/dagger/android/DispatchingAndroidInjector.html
[effective-java]: https://books.google.com/books?id=ka2VUBqHiWkC
[ErrorProne]: https://github.com/google/error-prone
[`HasDispatchingActivityInjector`]: https://google.github.io/dagger/api/latest/dagger/android/HasDispatchingActivityInjector.html
[`HasDispatchingFragmentInjector`]: https://google.github.io/dagger/api/latest/dagger/android/HasDispatchingFragmentInjector.html
[ProGuard]: http://proguard.sourceforge.net/
Expand Down