shelf_router_generator: does not handle $ in the URL

[kevmoo]

See https://github.com/dart-lang/json_serializable/blob/master/json_serializable/lib/src/utils.dart#L168 for help!

[jonasfj]

I assume this is a problem with code generation when the URL-patterns contain $, and not to do with the actual URLs for requests coming in.

We are using code.literal from package:code_builder, so this might be something that needs fixing there.

dart-neats/shelf_router_generator/lib/src/shelf_router_generator.dart

Lines 98 to 102 in 1cbc6bb

	return router.property('add').call([
	code.literal(handler.verb.toUpperCase()),
	code.literal(handler.route),
	service.property(handler.element.name),
	]).statement;

[kevmoo]

Correct. Code generation.

…

On Tue, Jun 18, 2019 at 5:36 AM Jonas Finnemann Jensen < ***@***.***> wrote: I assume this is a problem with code generation when the URL-patterns contain $, and not to do with the actual URLs for requests coming in. We are using code.literal from package:code_builder, so this might be something that needs fixing there. https://github.com/google/dart-neats/blob/1cbc6bb0e93e7df630d0582da51abc663adf206f/shelf_router_generator/lib/src/shelf_router_generator.dart#L98-L102 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#10?email_source=notifications&email_token=AAAEFCWMXFFSDOKP3HA4OUTP3DJFZA5CNFSM4HY3NEIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX6HN5Q#issuecomment-503084790>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAEFCUIFUOEMWIH2H6FETLP3DJFZANCNFSM4HY3NEIA> .

[jonasfj]

Fixed in #16.