Chocolatey deploy fix #56
Conversation
lib/src/chocolatey.dart
Outdated
| @@ -227,6 +227,7 @@ Future<void> _build() async { | |||
| writeString("build/chocolatey/$_chocolateyName.nuspec", _nuspec.toString()); | |||
| Directory("build/chocolatey/tools").createSync(); | |||
| writeString("build/chocolatey/tools/LICENSE", await license); | |||
| writeString("build/chocolatey/tools/VERIFICATION", ''); | |||
There was a problem hiding this comment.
What does this file do? Is it a problem that it's empty?
|
@nex3 Great question. When you deploy a package to Chocolatey, they run a validation script about some things that could be missing. One of them is this verification file, here is the error that shows up without it. https://github.com/chocolatey/package-validator/wiki/VerificationFileMissing You can use this to do checksum, but it is optional. TLDR; It's optional to have checksum verification, but the validator does ask for this file. |
|
@nex3 I believe this needs to be made as a parameter similar to the nuspec file later. I can try to take a look at this at a later time. But I believe you still need a VERIFICATION file even if it's empty. |
|
Looking at that link, it seems like this is intended to be a human-readable file that describes how binary files were generated. In our case, the only "binary" is the zip file containing the package's source code. I wonder if it would be easier to just include the source files directly, since the |
|
If we able to avoid I think it would be great. Makes things a bit cleaner. |
|
@nex3 Please let me know if you want me to try to take a look at your suggestion. Wasn't sure what the next steps are. |
|
Oh I'm sorry, I should have been more clear. Could you modify the code to copy in each source file directly to the Chocolatey package rather than creating a zip file containing all of them? |
Master sync
# Conflicts: # lib/src/chocolatey.dart
|
It looks like the tests are failing... |
|
I'm not sure why it's not showing up on GitHub, but its build did succeed. |
|
hmm ok will dig deeper |
…i_pkg into chocolatey-deploy-fix
|
Good news. Silly mistake. Will review the Chocolatey submission process to make sure we are good to go. However tests still fail on my local windows machine, but it happens on master also, so will check it out later and open another PR if anything. |
|
All validations passed on Chocolatey |
This reverts commit 01ed720. Now that google/dart_cli_pkg#56 has landed, Chocolatey deployment should work again.
This reverts commit 01ed720. Now that google/dart_cli_pkg#56 has landed, Chocolatey deployment should work again.
closes #49