Change SimpleSubmitHandler and angular page to use new DataTypes from portability-types-client #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holachuy
requested changes
Jan 30, 2018
| export class SimpleLoginComponent implements OnInit { | ||
| url = environment.apiPostUrl; | ||
| username: string = ""; | ||
| password: string = ""; | ||
| enableSubmit: boolean = false; | ||
| error_text: string = ""; | ||
| constructor() { } | ||
| constructor(private service : BackendService) { } |
There was a problem hiding this comment.
Run ng test and e2e tests to make sure we don't have to update anything to make them pass. Travis should pick up the failure, if there is one, too.
| @ApiModel | ||
| public class SimpleLoginRequest { | ||
| private final String username; | ||
| private final String password; |
There was a problem hiding this comment.
TODO: Determine how to avoid storing the password in the clear.
There was a problem hiding this comment.
Done. Note that this is also only used in the microsoft mail auth flow. We can delete it once we move that over to oauth or Live Sync.
holachuy
approved these changes
Jan 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires both a binary push and a static content deploy (#67)
This is the last piece to switching the portability-api to use the new data types (#71)