Migrate PortabilityJob, AuthData, and job stores to the new directory structure #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ectory structure, and deprecate the old versions. Also replace PersistentKeyValueStore with JobStore, and replace the following impls: - GooglePersistentKeyValueStore -> GoogleCloudDatastore implements JobStore - InMemoryPersistentKeyValueStore -> InMemoryKeyValueStore implements JobStore Tested locally with encryption flow on and off.
holachuy
requested changes
Feb 2, 2018
|
I'd prefer to move to the new PortabilityJob in a separate PR, this one already has a lot of changes and I haven't thought too much about how to port over yet. I just updated the name to LegacyPortabilityJob, good idea Also, FYI this is branched off of the other branch with the JobStore changes, so after this I'll send another PR to merge the whole thing into master |
holachuy
approved these changes
Feb 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make portability-core call PortabilityJob and AuthData in the new directory structure, and deprecate the old versions.
Also replace PersistentKeyValueStore with JobStore, and replace the following impls:
Tested locally with encryption flow on and off.