Updated Daybook posts importer to log bytes #1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D41685921
alexeyqu-fb
approved these changes
Dec 13, 2022
| @@ -155,6 +164,7 @@ private String insertActivity(SocialActivityModel activity, TokensAndUrlAuthData | |||
|
|
|||
| FormBody formBody = builder.build(); | |||
| requestBuilder.post(formBody); | |||
| size = formBody.contentLength(); | |||
There was a problem hiding this comment.
Ok but are we sure we want to log the payload size here?
E.g. what if the Daybook unpacks it / some fields in the form are stored more efficiently?
I'd say let's merge this and then check the numbers for real transfers..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Daybook posts importer to log bytes
NOTE: Dependent on #1197
Unlike in the case of other services, we don't seem to upload images in the importer. Instead, image URLs are being included in the form data, so, the size of the same is being logged.