Upgrade scribejava and flickr4java 3rd party libraries #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinStrong
force-pushed
the
upgrade-scribe-and-flickr4java
branch
4 times, most recently
from
a8eaff3
to
35af9ad
Compare
KevinStrong
commented
Jan 23, 2023
| @@ -131,6 +132,7 @@ SmugMugImageUploadResponse uploadImage( | |||
| headersMap.put("X-Smug-AlbumUri", albumUri); | |||
| headersMap.put("X-Smug-ResponseType", "JSON"); | |||
| headersMap.put("X-Smug-Version", "v2"); | |||
| headersMap.put("X-Smug-AlbumOverflow", "1"); | |||
There was a problem hiding this comment.
I didn't do this, where is it coming from? @seehamrun
KevinStrong
force-pushed
the
upgrade-scribe-and-flickr4java
branch
3 times, most recently
from
6b00059
to
0785ed4
Compare
seehamrun
previously approved these changes
Jan 24, 2023
KevinStrong
force-pushed
the
upgrade-scribe-and-flickr4java
branch
2 times, most recently
from
67e3f98
to
d3b362a
Compare
seehamrun
previously approved these changes
Jan 24, 2023
KevinStrong
force-pushed
the
upgrade-scribe-and-flickr4java
branch
2 times, most recently
from
2816fd0
to
aeefbf6
Compare
KevinStrong
force-pushed
the
upgrade-scribe-and-flickr4java
branch
from
aeefbf6
to
ffeff5a
Compare
seehamrun
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade the 3rd party libraries scribejava and flickr4java.
They have to be upgraded simultaneously because the flick4java interface exports scribejava.
The DTP interface, specifically with regard to declared exceptions, is kept that same despite changes to how flickr4java declares thrown exceptions.