noop(cleanup) delete duplicate importPhotos code from GooglePhotosImporter #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jzacsh
commented
Apr 17, 2023
•
jzacsh
commented
- WARNING: this should not be merged until google internal refactoring: factor out batch-import logic so we can (later PR) delete duplication that lives in GooglePhotosImporter #1234 is submitted (the diff won't even make much sense until then).
better to punt on actually integrating with GooglePhotosImporter until this is landed and is clearly understood as a small noop-diff of refactoring.
also leaves a TODO behind that we shouldn't be doing that in the first place. future-us problem.
seehamrun
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.