Add mocks for InputStream so that Imgur tests do not fail offline #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzacsh
reviewed
May 4, 2023
...gur/src/main/java/org/datatransferproject/datatransfer/imgur/photos/ImgurPhotosExporter.java
Show resolved
Hide resolved
...gur/src/main/java/org/datatransferproject/datatransfer/imgur/photos/ImgurPhotosExporter.java
Outdated
Show resolved
Hide resolved
jzacsh
reviewed
May 4, 2023
| // return new URL(imageUrl); | ||
| // } | ||
|
|
||
| public interface UrlFactory{ |
There was a problem hiding this comment.
I don't think you need this, btw. I think you can just declare the type of your urlFactory param to be Function<String, URL> urlFactory in your constructor.
There was a problem hiding this comment.
changed from interface to declaring the param type, thanks
jzacsh
requested changes
May 5, 2023
...mgur/src/test/java/org/datatransferproject/transfer/imgur/photos/ImgurPhotoExporterTest.java
Outdated
Show resolved
Hide resolved
|
LGTM! |
jzacsh
approved these changes
May 8, 2023
| URL u = null; | ||
| try { | ||
| u = spy(new URL(urlString)); | ||
| } catch (MalformedURLException e) { |
There was a problem hiding this comment.
(nit; up to you if you feel like tackling this right now)
i see why the try/catch in the real code, but probably not necessary in the test?
There was a problem hiding this comment.
The build failed without the try/catch, even with the call being in the test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1105