Update Google music models and Import/Export adapters #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
gauss0818
commented
Jul 14, 2023
gauss0818
commented
- With the latest change in Youtube Music Library Public API, we need to make the same change to google music models.
- We will not the insertion token for playlist anymore. Remove cache mapping in import adapter.
- Add music to demo server.
…nge in music public API
jzacsh
previously approved these changes
Jul 19, 2023
… google-music-import-export
…GoogleMusicExporter
jzacsh
previously approved these changes
Jul 20, 2023
...gle/src/main/java/org/datatransferproject/datatransfer/google/music/GoogleMusicExporter.java
Show resolved
Hide resolved
jzacsh
previously approved these changes
Jul 26, 2023
...src/test/java/org/datatransferproject/datatransfer/google/music/GoogleMusicImporterTest.java
Outdated
Show resolved
Hide resolved
gauss0818
force-pushed
the
google-music-import-export
branch
2 times, most recently
from
1ff2de1
to
006d966
Compare
jzacsh
approved these changes
Jul 26, 2023
alexeyqu-fb
pushed a commit
to alexeyqu-fb/data-transfer-project
that referenced
this pull request
Aug 15, 2023
Summary: * Update Google music models and Import/Export adapters with latest change in music public API * Add MUSIC service to GoogleTransferExtension; Add test usage code to GoogleMusicExporter * Add TODO to remove testing usage code * Add comment for null parameter Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D48350791
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.