Make JobStore impls use the new PortabilityJob for #126 #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… impls for new PortabilityJob methods
…ric format to use for key-value store implementations
holachuy
approved these changes
Feb 14, 2018
| @@ -88,29 +86,62 @@ public void create(UUID jobId, LegacyPortabilityJob job) throws IOException { | |||
| } | |||
|
|
|||
| /** | |||
| * Finds the {@link LegacyPortabilityJob} keyed by {@code jobId} in Datastore, or null if none found. | |||
| * Atomically updates the {@link LegacyPortabilityJob} keyed by {@code jobId} to {@code job}, | |||
There was a problem hiding this comment.
s/LegacyPortabilityJob/PortabilityJob
| Entity previousEntity = transaction.get(key); | ||
| if (previousEntity == null) { | ||
| transaction.rollback(); | ||
| throw new IOException("Could not find record for jobId " + jobId); |
There was a problem hiding this comment.
let's do jobId: " + jobId to distinguish parameterized values or any convention to highlight for future debugging
There was a problem hiding this comment.
Good point, done
Use consistent param name for jobId in debug statements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.