Make PortabilityJob an AutoValue class, including Jackson serialization #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ented (see PortabilityJobTest)
rtannenbaum
commented
Feb 20, 2018
| /** | ||
| * Tests serialization and deserialization of a {@link PortabilityJob}. | ||
| */ | ||
| public class PortabilityJobTest { |
There was a problem hiding this comment.
note: the rename of this class is because there used to be an extra "main" in the path (src/test/main/java/...)
seehamrun
reviewed
Feb 20, 2018
| objectMapper.readValue(serializedJob, PortabilityJob.class); | ||
| assertThat(deserializedJob).isEqualTo(job); | ||
| } | ||
| } |
| .put(EXPORT_SERVICE_KEY, exportService()) | ||
| .put(IMPORT_SERVICE_KEY, importService()) | ||
| .put(AUTHORIZATION_STATE, jobAuthorization().state().toString()) | ||
| .put(ENCRYPTED_SESSION_KEY, jobAuthorization().encryptedSessionKey()); |
There was a problem hiding this comment.
Does AutoValue check if these are null/empty too?
There was a problem hiding this comment.
Good point that I hadn't thought about- AutoValue guarantees the fields are non-null (since no @nullable annotation) but does not check for empty. But, there should be no harm in persisting an empty value in the map.
There was a problem hiding this comment.
Ack that makes sense! Thanks!
| @@ -0,0 +1,43 @@ | |||
| package org.dataportabilityproject.spi.cloud.types; | |||
seehamrun
approved these changes
Feb 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes boilerplate code and makes the class less error prone in regards to final and null variable state
See PortabilityJobTest for proof of serialization/deserialization
See note in slack channel for AutoValue/Gradle/IntelliJ instructions
Also makes PortabilityJob not inherit from EntityType any more. That inheritance broke json serialization, plus we had discussed getting rid of it anyway as EntityType is empty now.
fixes #4