Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor worker #184

Merged
merged 3 commits into from
Mar 7, 2018
Merged

Refactor worker #184

merged 3 commits into from
Mar 7, 2018

Conversation

rtannenbaum
Copy link
Contributor

for #172

holachuy
holachuy approved these changes Mar 7, 2018
View reviewed changes
Copy link
Collaborator

@holachuy holachuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting to refactor this

portability-worker/src/main/java/org/dataportabilityproject/worker/WorkerModule.java Outdated

@Override
public <T> T getConfiguration(String key, String defaultValue) {
return null;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO pass in flags?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks

portability-worker/src/main/java/org/dataportabilityproject/worker/JobMetadata.java Outdated
* initialization-on-demand holder idiom to ensure it is a singleton.
* A class that contains metadata for a worker's job.
*
* <p>This class is completely static to ensure it is a singleton within each worker instance.
*/
@Singleton
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove @singleton because iff we're using the static singleton approach, this won't be guice injected

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

rtannenbaum
rtannenbaum commented Mar 7, 2018
View reviewed changes
Copy link
Contributor Author

@rtannenbaum rtannenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, made those fixes

portability-worker/src/main/java/org/dataportabilityproject/worker/WorkerModule.java Outdated

@Override
public <T> T getConfiguration(String key, String defaultValue) {
return null;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks

portability-worker/src/main/java/org/dataportabilityproject/worker/JobMetadata.java Outdated
* initialization-on-demand holder idiom to ensure it is a singleton.
* A class that contains metadata for a worker's job.
*
* <p>This class is completely static to ensure it is a singleton within each worker instance.
*/
@Singleton
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@rtannenbaum rtannenbaum merged commit 2478b87 into master Mar 7, 2018
@rtannenbaum rtannenbaum deleted the refactor-worker branch March 7, 2018 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holachuy holachuy holachuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rtannenbaum @holachuy