Imgur Photo Exporter test #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holachuy
reviewed
Apr 5, 2019
| private static final String ALL_PHOTOS_URL_TEMPLATE = | ||
| BASE_URL + "/account/me/images/%s?perPage=" + RESULTS_PER_PAGE; | ||
| private static final String DEFAULT_ALBUM_ID = "defaultAlbumId"; | ||
| private static String albumPhotosUrlTemplate; |
There was a problem hiding this comment.
Can we remove static and add final to these. That way they, after they are assigned in the constructor, the won't be modified.
| private static final String CREATE_ALBUM_URL = BASE_URL + "/album"; | ||
| private static final String UPLOAD_PHOTO_URL = BASE_URL + "/image"; | ||
|
|
||
| private static String createAlbumUrl; |
There was a problem hiding this comment.
Likewise, if we can remove static and make both of these final.
...mgur/src/test/java/org/datatransferproject/transfer/imgur/photos/ImgurPhotoExporterTest.java
Outdated
Show resolved
Hide resolved
|
Hi Chuy, thanks for the review! I addressed comments, PTAL |
holachuy
approved these changes
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests for ImgurPhotoExporter ( #641)
Mockito doesn't allow to mock static fields or methods, so I refactored Exporter and Importer constructors to accept API URL instead of getting it from static variable. It was needed for mocking web server responses.
Also fixed Exception in the Importer (getting cache for a null value)