Make the DTP framework call the appropriate metric hooks #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uccess and duration metrics for jobs
holachuy
approved these changes
Apr 12, 2019
| Stopwatch stopwatch = Stopwatch.createStarted(); | ||
| try { | ||
| ExportResult result = exporterProvider.get().export(jobId, authData, exportInformation); | ||
| success = result.getType() != ExportResult.ResultType.ERROR; |
There was a problem hiding this comment.
For consistency with the importer, we should probably use == ResultType.OK for the success condition here.
There was a problem hiding this comment.
Ah, for export there are 3 conditions: END, CONTINUE, and ERROR, so I think we have to do != ERROR, or == with an or, so I think the != is cleaner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes importFinished and exportFinished as because we interleave the processing they don't make sense.
This addresses issue #41.