update angular frontend and api server to use types in portability-client-types #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holachuy
approved these changes
Jan 26, 2018
| @@ -56,22 +57,22 @@ public void handle(HttpExchange exchange) throws IOException { | |||
| Headers headers = exchange.getResponseHeaders(); | |||
| headers.set(HEADER_CONTENT_TYPE, "application/json; charset=" + StandardCharsets.UTF_8.name()); | |||
|
|
|||
| JsonArrayBuilder builder = Json.createArrayBuilder(); | |||
| Vector<String> data_types = new Vector<>(); | |||
There was a problem hiding this comment.
Done. Forgot that this wasnt C++ haha
seehamrun
added a commit
that referenced
this pull request
Jan 30, 2018
This updates the binary and static content with changes from #97 in prod and in qa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #71
This requires a new static content deploy and binary push (#67)
Let me know if this is on the right track. I created a couple of new "Response" type classes but am not sure if this is the model we want to use.