Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include advisories and licenses in dependency graphs? #16

Open
sarnesjo opened this issue May 2, 2023 · 3 comments
Open

Include advisories and licenses in dependency graphs? #16

sarnesjo opened this issue May 2, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@sarnesjo
Copy link

sarnesjo commented May 2, 2023

(Originally requested by @agmond in #3.)

Currently, to get a list of the advisories that affect a package version or one of its dependencies, a client:

  1. Calls GetDependencies.
  2. For each node in the response, calls GetVersion, ideally making many requests concurrently as in the package_lock_licenses example.

If the response from GetDependencies included advisories, only a single call would be needed. The same applies to licenses.

The downside is that the response would be larger (and slower to serve) for all clients, regardless of whether they are interested in advisories (or licenses).

@agmond
Copy link

agmond commented May 16, 2023

Regarding the downside mentioned above, it can be solved by adding a query param for including the additional data (or by adding a new API call that returns all the data in a single call, keeping the current API unchanged).

@adg adg added the enhancement New feature or request label May 30, 2023
@adg
Copy link
Collaborator

adg commented May 30, 2023

The extra data parameter is something we did in previous (internal) iterations of the API and it works pretty well, but we may end up just including all the data in the responses always (it's not a huge amount of extra information, and the cost server-side is not significant). This is on our roadmap.

@sgustafsson
Copy link

I was also looking for such a single API call to get package and dependency information (especially licensing information in my case) via a single API call. The website seems to do it via https://deps.dev/_/s/maven/p/org.everrest:everrest-core/v/1.15.0/dependencies . @adg mentioned a roadmap for such a single API call, any news on this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants