Skip to content
This repository has been archived by the owner on Aug 5, 2024. It is now read-only.

simplify encodeURI using HttpUtility #26

Merged
merged 1 commit into from
Aug 6, 2018
Merged

Conversation

jhgbrt
Copy link

@jhgbrt jhgbrt commented Jul 30, 2018

This simplifies the encodeURI function, using HttpUtility instead of Uri. Tests pass. I suspect this also to be more performant (although I didn't test this specifically).

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@jhgbrt
Copy link
Author

jhgbrt commented Jul 30, 2018

I signed it

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@jhgbrt
Copy link
Author

jhgbrt commented Jul 30, 2018

kthxbye

@jhgbrt jhgbrt closed this Jul 30, 2018
@jhgbrt jhgbrt reopened this Jul 31, 2018
@jhgbrt
Copy link
Author

jhgbrt commented Jul 31, 2018

I have signed the CLA, but googlebot insists I have not...

@NeilFraser
Copy link
Contributor

For the record, "jhgbrt" is logged as having signed the CLA. I'm satisfied that the legalities are taken care of, regardless of what our (slightly inflexible and possibly drunk) googlebot thinks.

@NeilFraser NeilFraser merged commit 4fdce26 into google:master Aug 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants