Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new elevator type #1038

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

new elevator type #1038

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
dc4cdd8
initial elevator type commit
kevin-hereworks May 17, 2023
079169d
initial elevator type commit
kevin-hereworks May 17, 2023
d66a283
changed entity name
kevin-hereworks May 17, 2023
1320a6a
added alarms
kevin-hereworks May 17, 2023
296befb
removed MONITORING
kevin-hereworks May 17, 2023
c51ec29
addede peak load alarm
kevin-hereworks May 17, 2023
96e7554
fixed field, addede states
kevin-hereworks May 17, 2023
08bd18f
Merge branch 'master' into new-elv-type
cstirdivant Jun 14, 2023
ddb72b2
updated type, states
kevin-hereworks Jun 16, 2023
efdc054
typo and removed unused states
kevin-hereworks Jun 16, 2023
7db3bbe
fixed states on telemetry field
kevin-hereworks Jun 16, 2023
a41a46f
ss, before epm, field to opt_uses
kevin-hereworks Jun 16, 2023
58d1998
changed field name
kevin-hereworks Jun 19, 2023
f3045ae
removed states and subfield
kevin-hereworks Jun 19, 2023
430d4ed
changed field name
kevin-hereworks Jun 19, 2023
6f513f9
Merge branch 'google:master' into new-elv-type
kevin-hereworks Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions ontology/yaml/resources/TRANSPORT/entity_types/ABSTRACT.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,11 @@ SS:
opt_uses:
- failed_alarm
- lost_power_alarm
- fire_alarm


EPM:
cstirdivant marked this conversation as resolved.
Show resolved Hide resolved
description: "Elevator position monitoring"
is_abstract: true
uses:
- floor_position_mode
9 changes: 9 additions & 0 deletions ontology/yaml/resources/TRANSPORT/entity_types/ELV.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,12 @@ ELV_SS:
- ELV
- SS

ELV_SS_EPM:
description: "Elevator with position/floor and basic alarms."
is_canonical: true
implements:
- ELV
- SS
- EPM
opt_uses:
- max_load_alarm
16 changes: 16 additions & 0 deletions ontology/yaml/resources/fields/telemetry_fields.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3110,3 +3110,19 @@ literals:
- ultraviolet_irradiance_sensor:
fixed_min: 0.0
flexible_max: 2000.0

- floor_position_mode:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the analytical benefit of knowing what floor the elevator is on? Please explain the use case more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah okay. I'm not the designer and on the surface probably not much benefit but I imagine it would be useful information to know the elevator usage trends when performing data analysis on the building information down the line?

- BASEMENT
- UPPERGROUND
- LOWERGROUND
- GROUND
- FIRST
- SECOND
- THIRD
- FOURTH
- FOURTHMEZ
- PLANTROOM

- max_load_alarm:
cstirdivant marked this conversation as resolved.
Show resolved Hide resolved
- ACTIVE
- INACTIVE
12 changes: 12 additions & 0 deletions ontology/yaml/resources/states/states.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,3 +90,15 @@ SOFTSTART: "Mode of operation of rectifier where the input power supply is gradu
NORMAL: "Function, state or flow which is an ideal or expected condition."
REVERSED: "Function, state or flow which is opposed to the expected or normal condition."

# For elevator
shambergoldstein marked this conversation as resolved.
Show resolved Hide resolved
BASEMENT: "Floor under ground level"
LOWERGROUND: "Mezzanine floor just below ground floor"
UPPERGROUND: "Mezzanine floor just above ground floor"
GROUND: "Street level floor in a building"

FIRST: "Function, state or Position number 1"
SECOND: "Function, state or Position number 2"
THIRD: "Function, state or Position number 3"
FOURTH: "Function, state or Position number 4"
FOURTHMEZ: "Mezzanine floor just above the fourth floor in a building"
PLANTROOM: "Room/Floor in a building with plant equipment"