-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new AHU & Abstract Type #1254
Conversation
@cstirdivant Added PR for HP3ZC |
Please add GUIDs |
@cstirdivant I believe the Ontology Validator check ran successfully. What else needs to be done to add the GUIDs? |
You must enable auto GUID generation for your PRs by following the instructions here https://github.com/google/digitalbuildings/blob/master/CONTRIBUTING.md#enabling-auto-guid-generation-for-prs Auto-generation does not work for your first PR (you submitted your first PR last week) -- if the GUIDs aren't automatically added, please add manually by generating an UUID4 (https://www.uuidgenerator.net/) and inserting into your branch. |
@cstirdivant I have the setting enabled for auto-generating GUIDs on my fork. Unclear why they do not generate after submitting PRs. |
Looks like the GUIDs are only generated on pushes to a branch called master. Is there a reason that the logic doesn't allow GUID generation on pull-requests to your master branch? I don't mind producing another PR to expand this to improve outside engagement, but I'm weary of stepping on toes (or there could be a darn good reason not to that I'm unfamiliar with). |
No description provided.