Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meter load connections #1341

Merged
merged 10 commits into from
May 24, 2024
Merged

Conversation

shambergoldstein
Copy link
Collaborator

No description provided.

ontology/docs/meter_loads.md Outdated Show resolved Hide resolved
ontology/docs/meter_loads.md Show resolved Hide resolved
@@ -22,3 +22,5 @@ HAS_PART:
description: "Source has some component or part defined by Target."
HAS_RANGE:
description: "Source has a coverage or detection range defined by Target."
MEASURES:
description: "Source provides data that is representative of Target load."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a good enough description; need to revise to remove the specificity about "load" -- measures is a more abstract concept where it defines the relationship between a source quantifying an attribute defined by the target

Copy link
Collaborator

@tasodorff tasodorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although would prefer connection between building and loadtypes to be something other than contains because that connection type doesn't really apply to abstract concepts. Its for physical connections. Can change in future.

@tasodorff tasodorff merged commit 42e94bc into google:master May 24, 2024
2 checks passed
@shambergoldstein shambergoldstein deleted the meter_load_connections branch June 25, 2024 16:19
@shambergoldstein shambergoldstein restored the meter_load_connections branch June 25, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants