Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docsy theme & enable 'print entire section' #85

Merged
merged 1 commit into from
Dec 10, 2020

Conversation

gwatts
Copy link
Contributor

@gwatts gwatts commented Nov 18, 2020

Turn on the "print entire section" feature that was pushed to Docsy.

Not sure how this is deployed, but might need to check it's using a relatively recent version of Hugo to deploy successfully.

@LisaFC
Copy link
Collaborator

LisaFC commented Dec 10, 2020

Thanks!

@LisaFC LisaFC merged commit 2cab944 into google:master Dec 10, 2020
@LisaFC
Copy link
Collaborator

LisaFC commented Dec 11, 2020

So this is weird, the regular build seems to be broken and it's barfing on something to do with the outputformat partial:

Error: "/opt/build/repo/themes/docsy/layouts/partials/outputformat.html:12:1": parse failed: template: partials/outputformat.html:12: function "return" not defined

I might try updating to an even more recent version of Docsy and see if that fixes it.

@gwatts
Copy link
Contributor Author

gwatts commented Dec 11, 2020

@LisaFC That sounds odd -- "return" was added to partials in Hugo 0.55 it appears; I assume you're building with at least that version or later?

@LisaFC
Copy link
Collaborator

LisaFC commented Dec 11, 2020

I thought so but let me check the Netlify config

@LisaFC
Copy link
Collaborator

LisaFC commented Dec 11, 2020

(the regular Docsy docs are building fine...)

@LisaFC
Copy link
Collaborator

LisaFC commented Dec 11, 2020

Ok, that'll teach me to not pay attention to anything that isn't actually in the repo - the Netlify build settings for this site are just in Netlify and hadn't been updated since 0.53 (I'm surprised the site has stayed up without errors for so long). Whoops. All working now!

@gwatts
Copy link
Contributor Author

gwatts commented Dec 11, 2020

Yay! Always nice when at least one problem of the day has a straightforward answer😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants