Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer Docsy as a single Hugo Module #1120

Closed
6 tasks done
Tracked by #1667
chalin opened this issue Jul 26, 2022 · 7 comments · Fixed by #1743
Closed
6 tasks done
Tracked by #1667

Offer Docsy as a single Hugo Module #1120

chalin opened this issue Jul 26, 2022 · 7 comments · Fixed by #1743
Assignees
Labels
CI/infra CI & infrastructure dependencies Pull requests that update a dependency file module
Milestone

Comments

@chalin
Copy link
Collaborator

chalin commented Jul 26, 2022

The intent would be to streamline use of Docsy for Hugo Module users, something which (IMHO) makes sense to do now that Git submodules were removed in 0.4.0, and NPM-package support is available (#949).

@deining - I can't find the thread, but at some point we discussed the possibility of eliminating the dependencies module, which was introduced as a means of addressing:

This issue is to record that intent, and offer a place for discussing it.

Tasks

References

@chalin chalin added CI/infra CI & infrastructure module labels Jul 26, 2022
@chalin chalin added the dependencies Pull requests that update a dependency file label Aug 18, 2022
@chalin
Copy link
Collaborator Author

chalin commented Aug 18, 2022

@deining @geriom - is this something that you might have time to do this quarter, or coach me on how to do it?

@deining
Copy link
Collaborator

deining commented Aug 18, 2022

@deining @geriom - is this something that you might have time to do this quarter, or coach me on how to do it?

Hi Patrice,
I will certainly find time to look into this shortly. I will inform you about the outcomings then. My very first thought is that even after removal of the submodules the situation we are facing is completely the same as before. But I might be wrong here, give me a bit of time to study the new situation and reflect on it.

@chalin
Copy link
Collaborator Author

chalin commented Aug 18, 2022

Thank you @deining! Btw, I'm ok at this point if there isn't a "smooth transition" moving forward for non-Hugo-module projects.

deining added a commit to deining/docsy that referenced this issue Sep 2, 2022
deining added a commit to deining/docsy that referenced this issue Sep 2, 2022
@deining
Copy link
Collaborator

deining commented Sep 2, 2022

The intent would be to streamline use of Docsy for Hugo Module users, something which (IMHO) makes sense to do now

I agree.

I'm ok at this point if there isn't a "smooth transition" moving forward for non-Hugo-module projects.

Great. that makes things a lot easier.

I worked on this issue (see PR #1217) and ended up with a consolidation of the two modules into one single docsy module, as proposed. With this PR applied, I can successfully run docsy from one single consolidated module. As expected, this single module isn't compatible and breaks existing installations based on npm or git submodules (see log of failed Netlify preview).

This issue is to record that intent, and offer a place for discussing it.

I hope my PR can serve as a good starting point for our discussion.

deining added a commit to deining/docsy that referenced this issue Oct 10, 2022
deining added a commit to deining/docsy that referenced this issue Oct 14, 2022
deining added a commit to deining/docsy that referenced this issue Oct 14, 2022
deining added a commit to deining/docsy that referenced this issue Oct 15, 2022
deining added a commit to deining/docsy that referenced this issue Oct 16, 2022
deining added a commit to deining/docsy that referenced this issue Oct 19, 2022
deining added a commit to deining/docsy that referenced this issue Oct 23, 2022
deining added a commit to deining/docsy that referenced this issue Oct 24, 2022
deining added a commit to deining/docsy that referenced this issue Oct 26, 2022
deining added a commit to deining/docsy that referenced this issue Oct 27, 2022
deining added a commit to deining/docsy that referenced this issue Oct 29, 2022
deining added a commit to deining/docsy that referenced this issue Oct 29, 2022
deining added a commit to deining/docsy that referenced this issue Nov 1, 2022
deining added a commit to deining/docsy that referenced this issue Nov 2, 2022
deining added a commit to deining/docsy that referenced this issue Nov 5, 2022
deining added a commit to deining/docsy that referenced this issue Nov 19, 2022
deining added a commit to deining/docsy that referenced this issue Nov 23, 2022
deining added a commit to deining/docsy that referenced this issue Nov 25, 2022
deining added a commit to deining/docsy that referenced this issue Dec 2, 2022
deining added a commit to deining/docsy that referenced this issue Dec 4, 2022
deining added a commit to deining/docsy that referenced this issue Dec 5, 2022
deining added a commit to deining/docsy that referenced this issue Dec 27, 2022
deining added a commit to deining/docsy that referenced this issue Dec 27, 2022
deining added a commit to deining/docsy that referenced this issue Jan 25, 2023
deining added a commit to deining/docsy that referenced this issue Mar 3, 2023
deining added a commit to deining/docsy that referenced this issue Jun 11, 2023
@chalin chalin mentioned this issue Nov 9, 2023
21 tasks
chalin pushed a commit to deining/docsy that referenced this issue Nov 9, 2023
deining added a commit to deining/docsy that referenced this issue Nov 9, 2023
deining added a commit to deining/docsy that referenced this issue Nov 9, 2023
chalin pushed a commit to deining/docsy that referenced this issue Nov 10, 2023
@chalin
Copy link
Collaborator Author

chalin commented Nov 10, 2023

Tasks

Now that #1217 is in, can you work on the other tasks too @deining?

@deining
Copy link
Collaborator

deining commented Nov 10, 2023

Now that #1217 is in, can you work on the other tasks too @deining?

Yes, I try to find time during to work on that during the weekend.

@chalin
Copy link
Collaborator Author

chalin commented Nov 16, 2023

@deining - FYI, I've address the remaining tasks for this issue, PTAL at:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure dependencies Pull requests that update a dependency file module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants