Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SCSS variable for FA font name #1170

Closed
Tracked by #1171
chalin opened this issue Aug 15, 2022 · 1 comment · Fixed by #1176
Closed
Tracked by #1171

Use SCSS variable for FA font name #1170

chalin opened this issue Aug 15, 2022 · 1 comment · Fixed by #1176
Assignees
@samiahmedsiddiqui

Comments

@chalin
Copy link
Collaborator

chalin commented Aug 15, 2022

We should define a variable for the FA font name and use it here and elsewhere. This can be done in this PR or a followup PR.

Originally posted by @chalin in #1102 (comment)
This was referenced Aug 15, 2022
Merged
Open
@samiahmedsiddiqui samiahmedsiddiqui mentioned this issue Aug 16, 2022
Merged
@samiahmedsiddiqui
Copy link
Contributor

@chalin Please review this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samiahmedsiddiqui samiahmedsiddiqui

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use SCSS variable for FA font name samiahmedsiddiqui/docsy
2 participants
@chalin @samiahmedsiddiqui