Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to FontAwesome 6 #1102

Merged
merged 3 commits into from
Aug 15, 2022
Merged

Conversation

samiahmedsiddiqui
Copy link
Contributor

@samiahmedsiddiqui samiahmedsiddiqui commented Jul 15, 2022

@google-cla
Copy link

google-cla bot commented Jul 15, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@samiahmedsiddiqui
Copy link
Contributor Author

@LisaFC @narrenfrei @raum51

@polarweasel
Copy link

@LisaFC and @raum51 could you have a look at this one? Fontawesome 6 would be very good to have by default, instead of us having to work around and add it manually. It looks like there's a Docsy release planned for fall, and we'd love to help get this into that.

@LisaFC
Copy link
Collaborator

LisaFC commented Aug 9, 2022

Will take a look - @chalin, can you take a look as well? Agree would be good to have the latest version for the next Docsy release. It doesn't look like it's likely to break anything but do FontAwesome themselves document any breaking changes? Don't want any users to suddenly end up with unexpected icons.

@chalin
Copy link
Collaborator

chalin commented Aug 9, 2022

Will take a look as soon as I can.
Please rebase & resolve the conflicts, thanks.

@samiahmedsiddiqui
Copy link
Contributor Author

@chalin conflicts resolved.

@polarweasel
Copy link

Backward compatibility information from the project: https://fontawesome.com/docs/web/setup/upgrade/whats-changed#backward-compatibility

Lots of icons got renamed, but the v5 names will still work. It'd be worth pointing to this table in the release notes, though, to make people aware that they should pick up the new names at some point.

Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Note that I haven't done an exhaustive search to see if any FA class names might have been missed, but what has been updated here works. Thanks!

See inline comment for suggested improvements for this or a followup PR.

assets/scss/_nav.scss Show resolved Hide resolved
layouts/partials/page-meta-links.html Outdated Show resolved Hide resolved
@chalin
Copy link
Collaborator

chalin commented Aug 15, 2022

Thanks @samiahmedsiddiqui for the PR. Thanks @polarweasel for the link to the backwards compatibility page.

FYI, some prep work which I'd like reviewed and merged before this PR:

Comments are welcome over on that PR.

@chalin chalin changed the title Update FontAwesome 5 to FontAwesome 6 Upgrade to FontAwesome 6 Aug 15, 2022
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comment regarding an issue with search placeholder text styling.

assets/scss/_search.scss Show resolved Hide resolved
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice step forward, doing the bulk of the upgrade. Will merge now (as agreed during PSC meeting) and follow up with further changes.

@chalin
Copy link
Collaborator

chalin commented Aug 15, 2022

I've collected the followup tasks in:

@samiahmedsiddiqui samiahmedsiddiqui deleted the updateFontAwesome branch August 16, 2022 05:47
fekete-robert pushed a commit to fekete-robert/docsy that referenced this pull request Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Font Awesome static files seem 3 years old?
4 participants