Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline search no longer works under Bootstrap v5 #1425

Closed
chalin opened this issue Feb 15, 2023 · 4 comments · Fixed by #1429
Closed

Offline search no longer works under Bootstrap v5 #1425

chalin opened this issue Feb 15, 2023 · 4 comments · Fixed by #1429
Labels
bug Something isn't working e1-hours p2-medium

Comments

@chalin
Copy link
Collaborator

chalin commented Feb 15, 2023

I tried to figure out what might be broken. I think it is because the usage has changed, compare:

At a minimum, the JS file will need to be udpated:

@chalin chalin mentioned this issue Feb 15, 2023
50 tasks
@chalin chalin added bug Something isn't working e1-hours p2-medium labels Feb 15, 2023
@chalin
Copy link
Collaborator Author

chalin commented Feb 15, 2023

@tekezo or @deining - might either of you be willing to work on this?

@chalin
Copy link
Collaborator Author

chalin commented Feb 15, 2023

@tekezo et al.: I've made an update for the arrow class name:

But I think that it might be necessary to change the template further. For example, maybe popover-body needs to be renamed to popover-inner? As I mentioned in the PR, for details, see:

@tekezo
Copy link
Contributor

tekezo commented Feb 16, 2023

Offline search starts working partially with my local commits.
I'll make PR later.
Screenshot 2023-02-16 at 23 56 10

@tekezo
Copy link
Contributor

tekezo commented Feb 16, 2023

@chalin I created PR for offline search updates for Bootstrap v5.
Please review it!
#1429

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working e1-hours p2-medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants