[BSv5] Adjusted offline search popover #1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great. @chalin does this fix the issue? |
|
Looks promising! 😄 Will carefully review as soon as I can. Thanks! |
chalin
force-pushed
the
bs5-offline-search
branch
from
b8646f9
to
5147324
Compare
|
Lovely! Here are some more screen shots, for the record: I generated these from the site using this diff: diff --git a/userguide/hugo.yaml b/userguide/hugo.yaml
index 54ef664..cc7aa7d 100644
--- a/userguide/hugo.yaml
+++ b/userguide/hugo.yaml
@@ -58,9 +58,9 @@ params:
time_format_blog: Monday, January 02, 2006
time_format_default: January 2, 2006
rss_sections: [blog] # TODO: drop since this is the default
- gcs_engine_id: 011217106833237091527:la2vtv2emlw
+ # gcs_engine_id: 011217106833237091527:la2vtv2emlw
algolia_docsearch: false
- offlineSearch: false
+ offlineSearch: true
offlineSearchSummaryLength: 70
offlineSearchMaxResults: 10
prism_syntax_highlighting: false |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$targetSearchInput.popover.new bootstrap.Popoverconstructor from$searchInput.data.customClassoption to addtd-offline-search-resultsclass instead of using template option.shown.bs.popoveris called more times than required when popover is shown multiple times.