Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-CDN resources #605

Open
Tracked by #1354
fnetX opened this issue Jun 18, 2021 · 6 comments
Open
Tracked by #1354

Support non-CDN resources #605

fnetX opened this issue Jun 18, 2021 · 6 comments
Labels
dependencies Pull requests that update a dependency file e1-hours e2-days enhancement New feature or request p1-high
Milestone

Comments

@fnetX
Copy link

fnetX commented Jun 18, 2021

Downloading resources from CDNs (esp. those who are behind Cloudflare) is questionable from a users' privacy perspective. Technically, they even have to be mentioned in the privacy statement as of German law here.

What do you think about adding a config option for not relying on external providers. When you don't want to update all dependencies in your repository, I'd even be fine manually overriding the URLs and updating them manually.

It'd be nice to hear your opinion and if this project is suitable for people caring about privacy at all, or if we should rather avoid it.

@LisaFC
Copy link
Collaborator

LisaFC commented Jun 23, 2021

I'm not sure how this would work as a config option, but you can always create your own copies of the relevant layouts and just put in your own URLs.

@gwatts, you mentioned this in #432, interested to hear your thoughts.

@dominikh
Copy link

I'm not sure how this would work as a config option, but you can always create your own copies of the relevant layouts and just put in your own URLs.

One possibility would be providing a URL to the resource in an option, which possibly defaults to a CDN for backwards compatibility. Devs concerned with privacy/the GDPR can put the appropriate files in their /static and link to those.

@Natureshadow
Copy link

Oh great. I just migrated my site to this theme, only to find it to load an incredible amount of external resources, completely ignoring any privacy regulations.

I should have known when seeing that it is made by Google…

@fnetX
Copy link
Author

fnetX commented May 11, 2022

For everyone landing here, I just want to recommend having a look at https://squidfunk.github.io/mkdocs-material/ - we went with it after docsy wasn't what we were looking for. It's awesome, somewhat lightweight compared to the amount of features, and the community is nice. 😉

@heinrich-ulbricht
Copy link

As heads-up: this topic currently gets some traction in Germany. People are getting fined for pulling in fonts from Google servers because this gives their IP address (which seems to be PII) to Google, without user consent. -> https://www.golem.de/news/google-fonts-abmahnungen-an-webseitenbetreiber-mit-google-schriftarten-2208-167472.html

@chalin chalin added the dependencies Pull requests that update a dependency file label Aug 18, 2022
@chalin chalin added the enhancement New feature or request label Aug 18, 2022
@chalin chalin changed the title Disable CDN resources Support non-CDN resources Aug 18, 2022
@chalin
Copy link
Collaborator

chalin commented Aug 18, 2022

Hi @fnetX! IMHO, this is a very reasonable request, and quite doable (since Hugo v0.90+). Sorry to see you go. Thanks for the link to Material for MkDocs, the resulting sites look amazing! I'm hoping that we can get inspiration from them.

@chalin chalin added this to the 24Q4 milestone Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file e1-hours e2-days enhancement New feature or request p1-high
Projects
None yet
Development

No branches or pull requests

7 participants
@dominikh @Natureshadow @heinrich-ulbricht @chalin @LisaFC @fnetX and others