Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scripts: get bootstrap.js and popper.js at build time #1187

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Scripts: get bootstrap.js and popper.js at build time #1187

merged 1 commit into from
Aug 19, 2022

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Aug 18, 2022 •
edited
Loading

@chalin
Copy link
Collaborator Author

chalin commented Aug 18, 2022

As is mentioned in Components from the Bootstrap docs:

Tooltips and popovers [are used] for displaying and positioning (also requires Popper)

Tooltips are still working (they're used in the footer):

image

LisaFC
LisaFC approved these changes Aug 18, 2022
View reviewed changes
Copy link
Collaborator

@LisaFC LisaFC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chalin chalin merged commit 10fae88 into google:main Aug 19, 2022
@chalin chalin deleted the chalin-im-bs-from-package-2022-08-18 branch August 19, 2022 00:18
@chalin
Copy link
Collaborator Author

chalin commented Aug 19, 2022

Thanks for the review. Merged so that I can more easily experiment with:

@chalin chalin added dependencies Pull requests that update a dependency file bootstrap labels Aug 19, 2022
@deining
Copy link
Collaborator

deining commented Sep 2, 2022

This commit broke docsy module installations. We need to add a mount so that bootstrap.js becomes available with module installations (see PR #1216).

@deining deining removed their request for review September 2, 2022 08:01
fekete-robert pushed a commit to fekete-robert/docsy that referenced this pull request Sep 13, 2022
@chalin @fekete-robert
Scripts: get bootstrap.js and popper.js at build time (google#1187)
2726c8f
@LisaFC LisaFC mentioned this pull request Sep 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LisaFC LisaFC LisaFC approved these changes

@geriom geriom Awaiting requested review from geriom

Assignees
No one assigned
Labels
bootstrap dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chalin @deining @LisaFC