Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docsy as a Hugo module #849

Closed
15 tasks done
chalin opened this issue Jan 19, 2022 · 9 comments
Closed
15 tasks done

Docsy as a Hugo module #849

chalin opened this issue Jan 19, 2022 · 9 comments
Assignees
Labels
CI/infra CI & infrastructure module
Milestone

Comments

@chalin
Copy link
Collaborator

chalin commented Jan 19, 2022

@deining et all, let's use this issue to track tasks that are needed to support use of Docsy as a Hugo module.

References:

@chalin chalin added CI/infra CI & infrastructure module labels Feb 2, 2022
@chalin
Copy link
Collaborator Author

chalin commented Feb 2, 2022

@deining, you mention that this feature is ready on the feature-hugo-module branch. I'd like for our users (myself included) to test use of docsy from that branch. I'll test it out for projects using submodules, can someone else test it out via Hugo Modules?

@chalin
Copy link
Collaborator Author

chalin commented Feb 2, 2022

Ok, I've tested the feature-hugo-module branch on a project using docsy via submodules and I'm glad to confirm that nothing broke! 🎉

@chalin
Copy link
Collaborator Author

chalin commented Mar 28, 2022

Update: we should be wrapping up the docs this week, and getting the next release out soon after that.

@deining deining mentioned this issue Apr 4, 2022
4 tasks
@chalin
Copy link
Collaborator Author

chalin commented Apr 7, 2022

@deining - could you do the docsy-example updates (see the opening comment)?

@deining
Copy link
Collaborator

deining commented Apr 7, 2022

@deining - could you do the docsy-example updates

For these updates, we have to merge #170, #172 and #171, with ideally PR 171 being the last one merged. All 3 PRs were authored by me, and merging his own PRs has a smell. @chalin, can you please review and merge these PRs? Thanks.
Afterwards, we have to decide whether we want to apply tags to the example site as well. I would tend to say yes, and would chose identical tag v0.2.0 in both for docsy theme and for the example site.

@chalin
Copy link
Collaborator Author

chalin commented Apr 7, 2022

@deining - all three PRs have been merged (though not strictly in the order you suggested, sorry -- due to a hick up on my side).

Afterwards, we have to decide whether we want to apply tags to the example site as well. I would tend to say yes, and would chose identical tag v0.2.0 in both for docsy theme and for the example site.

That seems reasonable to me.

@chalin
Copy link
Collaborator Author

chalin commented Apr 8, 2022

@deining - just to be clear: I'm ok if you ahead and setup the tags on the example repo. If you'd prefer that I do it, let me know.

@chalin chalin mentioned this issue Apr 8, 2022
2 tasks
@chalin chalin added this to the 22Q1 milestone Apr 8, 2022
@chalin
Copy link
Collaborator Author

chalin commented Apr 8, 2022

Last, not directly related item was moved to #966. All done here 🎉, so closing.

@chalin chalin closed this as completed Apr 8, 2022
@deining
Copy link
Collaborator

deining commented Apr 28, 2022

@deining - just to be clear: I'm ok if you ahead and setup the tags on the example repo.

Done. Added tag v0.2.0 to the docsy-example repo and created a release from that tag. Added archive files for go-less installation and for the _vendor directory itself to the release. Wondering if we should add these _vendor archives to the 0.2.0 release of docsy itself (I see added value from this).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure module
Projects
None yet
Development

No branches or pull requests

2 participants