-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User guide: adding instructions on how to use and update docsy as hugo module #802
Conversation
e887a47
to
1a85756
Compare
Oh wow, this is amazing work!!! I like that we give users all the possible setup options so they can get started using their preferred workflow. I'll need to do a detailed review but will try to get to that over the next week or so. |
Yes, absolutely. I just made a test to verify: I cloned the docsy example, updated the submodule and ran That said, I wouldn't recommend (though it is certainly doable) switching back and forth between hugo module and git submodule appraoch. To be clear here: I envision that the hugo module approach becomes the de facto standard for new installations. Existing sites can convert their sites (which is really easy IMHO) but they don't have to. Another thought: too many installation options might be overwhelming for first time docsy, so if we agree that the module approach is the new standard, I ask myself, whether we shouldn't discard the sub section |
Glad to hear you like it.
Having a lot of options is good, but might be overwhelming for novices. I'm open for discussion here.
Great! As mentioned in #801, my PR is not ready for testing, I wish it were, I guess this would help you with your review, too.
I will then resubmit #801 on the newly created |
I think we can definitely reorganize your suggested docs a bit so that there's a default "happy path" set up to "get started" (so as not to confuse people) and then alternatives for those who want them. Would like to get feedback from the rest of the community on this! (particularly what we think most users will want as the default) |
Done and done! |
If use of Hugo modules is the way to go, then this seems great! Thanks @deining! I'll take a closer look as soon as I can. |
d22687e
to
cfbca8f
Compare
Hi, what is the update here? We are using dependabot for git submodules but since this change our build fails with the message I found the documentation about the switch here in this Pull Request, but I feel this should be released ASAP as maybe there are other people having the same problem Edit: Also I have quite a few problems using the migration guide, all of a sudden a page cannot be found and the known bug in the explanation is there, too. Is there a way to work without this workaround? |
79d7f7f
to
2e0a339
Compare
This documentation is now fully in sync with #871 and ready to be reviewed. |
Ok, thanks, I'll have a look as soon as I can (starting tomorrow). |
Similarly, I'll take a look ASAP when I have a chance (probably tomorrow) |
8523f9c
to
0c2cbf9
Compare
...as left nav is getting very big...
OK, I'll merge in the "Docsy Example with Hugo Modules" PR and then merge this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Done! Shall we commence making Glorious Announcements? |
Instructions on how to make use of Docsy as hugo module, as submitted via #801.
More or less a complete rewrite of the chapters
Getting started
(now:Installation
) andUpdating Docsy
(now:Update or Conversion of Docsy Theme
) from the user guide. Given links point to the preview of the chapters on Netlify. Enjoy reading!