Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hugo relURL fix for CSS and JS paths #1127

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Jul 27, 2022

/cc @Marzal @daniel-milchev @deining

@chalin chalin requested review from geriom and LisaFC July 27, 2022 15:58
@chalin
Copy link
Collaborator Author

chalin commented Jul 27, 2022

No changes to the generated UG files, and it fixes one of the Docsy-based projects -- as reported via eclipse-kanto/kanto#57:

image

Note that the styling of the code blocks is working once again.

So I'll merge now and hopefully the Kanto project folks (like @daniel-milchev) can confirm the fix.

@Marzal
Copy link
Contributor

Marzal commented Jul 27, 2022

Thanks for the quick fix.

I only have doubts about this one:
https://github.com/google/docsy/blob/main/layouts/404.html#L5
<p>Oops! This page doesn't exist. Try going back to our <a href="{{ "/" | relURL }}">home page</a>.</p>
Some other projects put "" in similar cases
toppers/hakoniwa@ccdd258#diff-42986cf40ad96f5b7ca39d9b71ba6a9f252656de24cfe82100892ff0f4400f90L4

@chalin
Copy link
Collaborator Author

chalin commented Jul 27, 2022

Thanks for the reference and the feedback. I've moved your comment into the issue -- #1114 (comment) -- since the issue is still open (I left it open because I knew that there might be more issues to address, like the ones that you're pointing out).

@daniel-milchev
Copy link

Thank you for the quick fix!
The problem with the code snippets has been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants