Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcode imgproc: add crop command #1272

Merged
merged 1 commit into from Feb 3, 2023
Merged

Conversation

deining
Copy link
Collaborator

@deining deining commented Oct 11, 2022

This PR adds the cropcommand to the available image processing options of the imgproc shortcode. Since hugo uses Smartcrop image analysis to determine the optimal placement of the crop box, I don't see any reason to exclude this option.
This PR also corrects an incorrect link in the documentation of the shortcode.

Preview: https://deploy-preview-1272--docsydocs.netlify.app/docs/adding-content/shortcodes/#imgproc

@deining deining added user guide Improvements to user guide shortcodes Hugo shortcodes labels Oct 11, 2022
@deining deining force-pushed the shortcode_imgproc branch 5 times, most recently from ed16011 to 932cd7a Compare October 19, 2022 12:22
@deining deining force-pushed the shortcode_imgproc branch 4 times, most recently from daea962 to f887686 Compare October 29, 2022 05:24
@deining deining force-pushed the shortcode_imgproc branch 3 times, most recently from 4bc18fb to 22b0394 Compare December 5, 2022 20:02
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One inline comment. Otherwise, LGTM.

@chalin chalin merged commit a497c22 into google:main Feb 3, 2023
@deining deining deleted the shortcode_imgproc branch February 3, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
shortcodes Hugo shortcodes user guide Improvements to user guide
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants